Page MenuHomePhabricator

[alias spec] Add Version
ClosedPublic

Authored by Mengerian on Apr 28 2023, 21:56.

Details

Reviewers
Fabien
bytesofman
Group Reviewers
Restricted Project
Commits
rABCf5565cc40e94: [alias spec] Add Version
Summary

Facilitates possible future changes to Alias registrations

Test Plan

Read it

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

See D13826 for an implementation

Two differences between D13826 and this spec

  1. In D13826, Alias registration tx version number is pushed with the alias and not on its own (is this a bad idea?)
  2. In D13826, the alias is pushed first, then the address

This is just how I happened to build it. Let me know suggested improvements. We'll make sure D13826 and this spec agree with each other before landing.

In D13826, Alias registration tx version number is pushed with the alias and not on its own (is this a bad idea?)

That's what we discussed during the call: having a separate push for the version makes it easier to later add more options within that push without having to deal with the alias push itself. This makes for easier backward compatibility at the expense of (currently) 1 more byte in the OP_RETURN.

In D13826, the alias is pushed first, then the address

No opinion on that, except that this is not a change from this diff.

This revision is now accepted and ready to land.May 1 2023, 10:02

Flip order of Alias and address pushes

This revision was automatically updated to reflect the committed changes.