Adding h2 componenet. It packages the commonly used h2 with the graphic and subheadline that is used throughout the site into one reusable component that takes a text and subtext prop
Details
Details
- Reviewers
bytesofman - Group Reviewers
Restricted Project - Commits
- rABC65f017b1fab4: [e.cash] Add H2 component
npm run dev
check the component renders correctly
try changing the text for the subtext and text prop
ensure it updates properly
@bot preview-e.cash
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- ecash-h2
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 23623 Build 46860: Build Diff Build 46859: arc lint + arc unit
Event Timeline
Comment Actions
Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://54.39.19.73:41864 for the next 60 minutes.
Comment Actions
i.e. even just making the left padding correct like what we see at e.cash
component does look nice, but hard to review with it just chilling there. Is it practical to add the code required to show it in the first spot it will go?
i.e. even just making the left padding correct like what we see at e.cash
potential issue with stealth mode, background is still blue-ish
Comment Actions
@bot preview-e.cash
| web/e.cash/styles/pages/homepage.js | ||
|---|---|---|
| 89 ↗ | (On Diff #40189) | Is this really HomepageBody, i.e. will this contain everything under the upper header / hero section? If not, then should refer to the section(s) it will contain. |
Comment Actions
Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) failed.
Tail of the build log:
#7 3.706 #7 3.706 found 0 vulnerabilities #7 3.706 npm notice #7 3.706 npm notice New major version of npm available! 8.19.4 -> 9.6.6 #7 3.706 npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.6.6> #7 3.706 npm notice Run `npm install -g npm@9.6.6` to update! #7 3.706 npm notice #7 DONE 6.5s #8 [4/4] RUN npm run build #8 sha256:74dd3c86a992396428ed9a699f9650aed1b8049de3803cbb2fa66c50b6b0a99c #8 0.825 #8 0.825 > e.cash@0.0.1 build #8 0.825 > next build #8 0.825 #8 1.214 Attention: Next.js now collects completely anonymous telemetry regarding usage. #8 1.216 This information is used to shape Next.js' roadmap and prioritize features. #8 1.216 You can learn more, including how to opt-out if you'd not like to participate in this anonymous program, by visiting the following URL: #8 1.216 https://nextjs.org/telemetry #8 1.216 #8 1.349 info - Linting and checking validity of types... #8 1.563 info - Creating an optimized production build... #8 2.114 Warning: For production Image Optimization with Next.js, the optional 'sharp' package is strongly recommended. Run 'yarn add sharp', and Next.js will use it automatically for Image Optimization. #8 2.114 Read more: https://nextjs.org/docs/messages/sharp-missing-in-production #8 4.685 info - Compiled successfully #8 4.685 info - Collecting page data... #8 5.687 info - Generating static pages (0/3) #8 5.844 #8 5.844 Error occurred prerendering page "/". Read more: https://nextjs.org/docs/messages/prerender-error #8 5.844 ReferenceError: H2 is not defined #8 5.844 at Home (/.next/server/pages/index.js:1295:66) #8 5.844 at Wc (/node_modules/react-dom/cjs/react-dom-server.browser.production.min.js:68:44) #8 5.844 at Zc (/node_modules/react-dom/cjs/react-dom-server.browser.production.min.js:70:253) #8 5.844 at Z (/node_modules/react-dom/cjs/react-dom-server.browser.production.min.js:76:89) #8 5.844 at $c (/node_modules/react-dom/cjs/react-dom-server.browser.production.min.js:78:98) #8 5.844 at bd (/node_modules/react-dom/cjs/react-dom-server.browser.production.min.js:77:404) #8 5.844 at Z (/node_modules/react-dom/cjs/react-dom-server.browser.production.min.js:76:217) #8 5.844 at Zc (/node_modules/react-dom/cjs/react-dom-server.browser.production.min.js:74:209) #8 5.844 at Z (/node_modules/react-dom/cjs/react-dom-server.browser.production.min.js:76:89) #8 5.844 at Zc (/node_modules/react-dom/cjs/react-dom-server.browser.production.min.js:70:481) #8 5.863 info - Generating static pages (3/3) #8 5.864 #8 5.864 > Build error occurred #8 5.866 Error: Export encountered errors on following paths: #8 5.866 / #8 5.866 at /node_modules/next/dist/export/index.js:415:19 #8 5.866 at runMicrotasks (<anonymous>) #8 5.866 at processTicksAndRejections (node:internal/process/task_queues:96:5) #8 5.866 at async Span.traceAsyncFn (/node_modules/next/dist/trace/trace.js:79:20) #8 5.866 at async /node_modules/next/dist/build/index.js:1400:21 #8 5.866 at async Span.traceAsyncFn (/node_modules/next/dist/trace/trace.js:79:20) #8 5.866 at async /node_modules/next/dist/build/index.js:1259:17 #8 5.866 at async Span.traceAsyncFn (/node_modules/next/dist/trace/trace.js:79:20) #8 5.866 at async Object.build [as default] (/node_modules/next/dist/build/index.js:66:29) #8 ERROR: executor failed running [/bin/sh -c npm run build]: exit code: 1 ------ > [4/4] RUN npm run build: ------ executor failed running [/bin/sh -c npm run build]: exit code: 1 Build preview-e.cash failed with exit code 1
| web/e.cash/pages/index.js | ||
|---|---|---|
| 68 ↗ | (On Diff #40191) | need to import this H2, see teamcity error |
Comment Actions
Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://54.39.104.128:41870 for the next 60 minutes.
Comment Actions
Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://54.39.104.128:41011 for the next 60 minutes.