Page MenuHomePhabricator
Differential D13867

[Cashtab] Support alias registration of user input addresses
ClosedPublic
Actions

Authored by bytesofman on May 8 2023, 18:10.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCaff2d5a7752d: [Cashtab] Support alias registration of user input addresses
Summary

T3060

Support user input of address for alias registration

The Alias.js screen loads with a checkbox selected indicating that the alias will be registered to the active wallet's address.

The user may uncheck this box and enter an address of their choosing, P2SH or P2PKH. User input is validated.

Note: alias-server has not yet been updated to parse these txs.

Test Plan

npm test
In components/common/Ticker.js, change the aliasSettings.aliasEnabled bool to true
npm start
Navigate to the Alias.js screen. Confirm checkbox is checked.
Register an alias without unchecking the box.
Uncheck the box.
Confirm alias address input form appears.
Enter an invalid address and confirm validation error.
Enter a valid address and confirm validation error disappears, 'Register Alias' button is enabled (if alias input is valid)
Register this alias
Try registering to a p2sh address, like the IFP address ecash:prfhcnyqnl5cgrnmlfmms675w93ld7mvvqd0y8lz07

Diff Detail

Repository
rABC Bitcoin ABC
Branch
alias-support-address-input
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 23655
Build 46924: Build Diffcashtab-tests
Build 46923: arc lint + arc unit

Event Timeline

bytesofman created this revision.May 8 2023, 18:10
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 8 2023, 18:10
bytesofman requested review of this revision.May 8 2023, 18:10
Harbormaster completed remote builds in B23655: Diff 40228.May 8 2023, 18:15
teamcity added a comment.May 8 2023, 18:15
Build Bitcoin ABC Diffs / Diff Testing (cashtab-tests) failed.

Failed tests logs:

====== CashTab Unit Tests:  Wallet with BCH balances and tokens and state field ======
Error: expect(received).toMatchSnapshot()

Snapshot name: `Wallet with BCH balances and tokens and state field 1`

- Snapshot  - 1
+ Received  + 1

@@ -94,11 +94,11 @@
                              name="address"
                              onBlur={[Function]}
                              onChange={[Function]}
                              onFocus={[Function]}
                              onKeyDown={[Function]}
-                             placeholder="Address or Alias"
+                             placeholder="Address"
                              required={true}
                              style={null}
                              type="text"
                              value=""
                            />
    at Object.<anonymous> (/work/cashtab/src/components/Send/__tests__/SendToken.test.js:66:18)
    at Promise.then.completed (/work/cashtab/node_modules/jest-circus/build/utils.js:391:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (/work/cashtab/node_modules/jest-circus/build/utils.js:316:10)
    at _callCircusTest (/work/cashtab/node_modules/jest-circus/build/run.js:218:40)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at _runTest (/work/cashtab/node_modules/jest-circus/build/run.js:155:3)
    at _runTestsForDescribeBlock (/work/cashtab/node_modules/jest-circus/build/run.js:66:9)
    at run (/work/cashtab/node_modules/jest-circus/build/run.js:25:3)
    at runAndTransformResultsToJestFormat (/work/cashtab/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapterInit.js:170:21)
    at jestAdapter (/work/cashtab/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:82:19)
    at runTestInternal (/work/cashtab/node_modules/jest-runner/build/runTest.js:389:16)
    at runTest (/work/cashtab/node_modules/jest-runner/build/runTest.js:475:34)
    at Object.worker (/work/cashtab/node_modules/jest-runner/build/testWorker.js:133:12)Error: expect(received).toMatchSnapshot()

Snapshot name: `Wallet with BCH balances and tokens and state field 1`

- Snapshot  - 1
+ Received  + 1

@@ -197,11 +197,11 @@
                                      name="address"
                                      onBlur={[Function]}
                                      onChange={[Function]}
                                      onFocus={[Function]}
                                      onKeyDown={[Function]}
-                                     placeholder="Address or Alias"
+                                     placeholder="Address"
                                      required={true}
                                      style={null}
                                      type="text"
                                      value=""
                                    />
    at Object.<anonymous> (/work/cashtab/src/components/Send/__tests__/Send.test.js:88:18)
    at Promise.then.completed (/work/cashtab/node_modules/jest-circus/build/utils.js:391:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (/work/cashtab/node_modules/jest-circus/build/utils.js:316:10)
    at _callCircusTest (/work/cashtab/node_modules/jest-circus/build/run.js:218:40)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at _runTest (/work/cashtab/node_modules/jest-circus/build/run.js:155:3)
    at _runTestsForDescribeBlock (/work/cashtab/node_modules/jest-circus/build/run.js:66:9)
    at run (/work/cashtab/node_modules/jest-circus/build/run.js:25:3)
    at runAndTransformResultsToJestFormat (/work/cashtab/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapterInit.js:170:21)
    at jestAdapter (/work/cashtab/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:82:19)
    at runTestInternal (/work/cashtab/node_modules/jest-runner/build/runTest.js:389:16)
    at runTest (/work/cashtab/node_modules/jest-runner/build/runTest.js:475:34)
    at Object.worker (/work/cashtab/node_modules/jest-runner/build/testWorker.js:133:12)
====== CashTab Unit Tests:  Wallet without BCH balance ======
Error: expect(received).toMatchSnapshot()

Snapshot name: `Wallet without BCH balance 1`

- Snapshot  - 1
+ Received  + 1

@@ -192,11 +192,11 @@
                                      name="address"
                                      onBlur={[Function]}
                                      onChange={[Function]}
                                      onFocus={[Function]}
                                      onKeyDown={[Function]}
-                                     placeholder="Address or Alias"
+                                     placeholder="Address"
                                      required={true}
                                      style={null}
                                      type="text"
                                      value=""
                                    />
    at Object.<anonymous> (/work/cashtab/src/components/Send/__tests__/Send.test.js:44:18)
    at Promise.then.completed (/work/cashtab/node_modules/jest-circus/build/utils.js:391:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (/work/cashtab/node_modules/jest-circus/build/utils.js:316:10)
    at _callCircusTest (/work/cashtab/node_modules/jest-circus/build/run.js:218:40)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at _runTest (/work/cashtab/node_modules/jest-circus/build/run.js:155:3)
    at _runTestsForDescribeBlock (/work/cashtab/node_modules/jest-circus/build/run.js:66:9)
    at run (/work/cashtab/node_modules/jest-circus/build/run.js:25:3)
    at runAndTransformResultsToJestFormat (/work/cashtab/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapterInit.js:170:21)
    at jestAdapter (/work/cashtab/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:82:19)
    at runTestInternal (/work/cashtab/node_modules/jest-runner/build/runTest.js:389:16)
    at runTest (/work/cashtab/node_modules/jest-runner/build/runTest.js:475:34)
    at Object.worker (/work/cashtab/node_modules/jest-runner/build/testWorker.js:133:12)
====== CashTab Unit Tests:  Wallet with BCH balances ======
Error: expect(received).toMatchSnapshot()

Snapshot name: `Wallet with BCH balances 1`

- Snapshot  - 1
+ Received  + 1

@@ -192,11 +192,11 @@
                                      name="address"
                                      onBlur={[Function]}
                                      onChange={[Function]}
                                      onFocus={[Function]}
                                      onKeyDown={[Function]}
-                                     placeholder="Address or Alias"
+                                     placeholder="Address"
                                      required={true}
                                      style={null}
                                      type="text"
                                      value=""
                                    />
    at Object.<anonymous> (/work/cashtab/src/components/Send/__tests__/Send.test.js:58:18)
    at Promise.then.completed (/work/cashtab/node_modules/jest-circus/build/utils.js:391:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (/work/cashtab/node_modules/jest-circus/build/utils.js:316:10)
    at _callCircusTest (/work/cashtab/node_modules/jest-circus/build/run.js:218:40)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at _runTest (/work/cashtab/node_modules/jest-circus/build/run.js:155:3)
    at _runTestsForDescribeBlock (/work/cashtab/node_modules/jest-circus/build/run.js:66:9)
    at run (/work/cashtab/node_modules/jest-circus/build/run.js:25:3)
    at runAndTransformResultsToJestFormat (/work/cashtab/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapterInit.js:170:21)
    at jestAdapter (/work/cashtab/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:82:19)
    at runTestInternal (/work/cashtab/node_modules/jest-runner/build/runTest.js:389:16)
    at runTest (/work/cashtab/node_modules/jest-runner/build/runTest.js:475:34)
    at Object.worker (/work/cashtab/node_modules/jest-runner/build/testWorker.js:133:12)
====== CashTab Unit Tests:  Wallet with BCH balances and tokens ======
Error: expect(received).toMatchSnapshot()

Snapshot name: `Wallet with BCH balances and tokens 1`

- Snapshot  - 1
+ Received  + 1

@@ -192,11 +192,11 @@
                                      name="address"
                                      onBlur={[Function]}
                                      onChange={[Function]}
                                      onFocus={[Function]}
                                      onKeyDown={[Function]}
-                                     placeholder="Address or Alias"
+                                     placeholder="Address"
                                      required={true}
                                      style={null}
                                      type="text"
                                      value=""
                                    />
    at Object.<anonymous> (/work/cashtab/src/components/Send/__tests__/Send.test.js:72:18)
    at Promise.then.completed (/work/cashtab/node_modules/jest-circus/build/utils.js:391:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (/work/cashtab/node_modules/jest-circus/build/utils.js:316:10)
    at _callCircusTest (/work/cashtab/node_modules/jest-circus/build/run.js:218:40)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at _runTest (/work/cashtab/node_modules/jest-circus/build/run.js:155:3)
    at _runTestsForDescribeBlock (/work/cashtab/node_modules/jest-circus/build/run.js:66:9)
    at run (/work/cashtab/node_modules/jest-circus/build/run.js:25:3)
    at runAndTransformResultsToJestFormat (/work/cashtab/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapterInit.js:170:21)
    at jestAdapter (/work/cashtab/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:82:19)
    at runTestInternal (/work/cashtab/node_modules/jest-runner/build/runTest.js:389:16)
    at runTest (/work/cashtab/node_modules/jest-runner/build/runTest.js:475:34)
    at Object.worker (/work/cashtab/node_modules/jest-runner/build/testWorker.js:133:12)
====== CashTab Unit Tests:  Without wallet defined ======
Error: expect(received).toMatchSnapshot()

Snapshot name: `Without wallet defined 1`

- Snapshot  - 1
+ Received  + 1

@@ -187,11 +187,11 @@
                                      name="address"
                                      onBlur={[Function]}
                                      onChange={[Function]}
                                      onFocus={[Function]}
                                      onKeyDown={[Function]}
-                                     placeholder="Address or Alias"
+                                     placeholder="Address"
                                      required={true}
                                      style={null}
                                      type="text"
                                      value=""
                                    />
    at Object.<anonymous> (/work/cashtab/src/components/Send/__tests__/Send.test.js:107:18)
    at Promise.then.completed (/work/cashtab/node_modules/jest-circus/build/utils.js:391:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (/work/cashtab/node_modules/jest-circus/build/utils.js:316:10)
    at _callCircusTest (/work/cashtab/node_modules/jest-circus/build/run.js:218:40)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at _runTest (/work/cashtab/node_modules/jest-circus/build/run.js:155:3)
    at _runTestsForDescribeBlock (/work/cashtab/node_modules/jest-circus/build/run.js:66:9)
    at run (/work/cashtab/node_modules/jest-circus/build/run.js:25:3)
    at runAndTransformResultsToJestFormat (/work/cashtab/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapterInit.js:170:21)
    at jestAdapter (/work/cashtab/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:82:19)
    at runTestInternal (/work/cashtab/node_modules/jest-runner/build/runTest.js:389:16)
    at runTest (/work/cashtab/node_modules/jest-runner/build/runTest.js:475:34)
    at Object.worker (/work/cashtab/node_modules/jest-runner/build/testWorker.js:133:12)

Each failure log is accessible here:
CashTab Unit Tests: Wallet with BCH balances and tokens and state field
CashTab Unit Tests: Wallet without BCH balance
CashTab Unit Tests: Wallet with BCH balances
CashTab Unit Tests: Wallet with BCH balances and tokens
CashTab Unit Tests: Without wallet defined

bytesofman updated this revision to Diff 40229.May 8 2023, 18:18

Improving code comments

Harbormaster completed remote builds in B23656: Diff 40229.May 8 2023, 18:22
Fabien requested changes to this revision.May 9 2023, 07:50
Fabien added a subscriber: Fabien.
Fabien added inline comments.
cashtab/src/components/Alias/Alias.js
117 ↗(On Diff #40229)

Macro notaloop:

307 ↗(On Diff #40229)
311 ↗(On Diff #40229)

IMO that's not very useful as a comment. You're documenting the test fixtures in the function itself, which is unrelated

313 ↗(On Diff #40229)
348 ↗(On Diff #40229)

Dito

367 ↗(On Diff #40229)

You should trim before you check for validity, not after, so that leading/trailing whitespaces that often occur during copy/pasting are ignored.
Also why do you need this check at all ? If value is an empty string the address will be invalid. If not that's a bug and it needs to be fixed separately.

This revision now requires changes to proceed.May 9 2023, 07:50
Fabien added a comment.May 9 2023, 07:50

@bot preview-cashtab

teamcity awarded a token.May 9 2023, 07:50

Build Bitcoin ABC Diffs / Diff Testing (preview-cashtab) passed.
Preview is available at http://54.39.104.128:41799 for the next 60 minutes.

bytesofman marked 6 inline comments as done.May 9 2023, 14:24
In D13867#309250, @Fabien wrote:

@bot preview-cashtab

Note that it's not possible to test this as Ticker.js must be manually updated to enable the Alias screen

I could push diffs with this set to true, which would allow previews to work. But then might accidentally land one with aliases enabled.

bytesofman updated this revision to Diff 40236.May 9 2023, 14:26

Responding to feedback

Harbormaster completed remote builds in B23663: Diff 40236.May 9 2023, 14:29
Fabien accepted this revision.May 10 2023, 14:13
This revision is now accepted and ready to land.May 10 2023, 14:13
Closed by commit rABCaff2d5a7752d: [Cashtab] Support alias registration of user input addresses (authored by bytesofman). · Explain WhyMay 10 2023, 19:06
This revision was automatically updated to reflect the committed changes.
bytesofman added a commit: rABCaff2d5a7752d: [Cashtab] Support alias registration of user input addresses.

Revision Contents
Changeset List

PathSize
cashtab/
src/
components/
Airdrop/
__tests__/
__snapshots__/
Alias/
127 lines
__tests__/
__snapshots__/
Common/
6 lines
49 lines
Configure/
__tests__/
__snapshots__/
Home/
__tests__/
__snapshots__/
Receive/
__tests__/
__snapshots__/
Send/
__tests__/
__snapshots__/
SignVerifyMsg/
__tests__/
__snapshots__/
Tokens/
__tests__/
__snapshots__/

Diff 40228

View Options

cashtab/src/components/Airdrop/__tests__/__snapshots__/Airdrop.test.js.snap

Loading...
View Options

cashtab/src/components/Alias/Alias.js

Loading...
View Options

cashtab/src/components/Alias/__tests__/__snapshots__/Alias.test.js.snap

Loading...
View Options

cashtab/src/components/Common/CustomIcons.js

Loading...
View Options

cashtab/src/components/Common/EnhancedInputs.js

Loading...
View Options

cashtab/src/components/Configure/__tests__/__snapshots__/Configure.test.js.snap

Loading...
View Options

cashtab/src/components/Home/__tests__/__snapshots__/Home.test.js.snap

Loading...
View Options

cashtab/src/components/Receive/__tests__/__snapshots__/Receive.test.js.snap

Loading...
View Options

cashtab/src/components/Send/__tests__/__snapshots__/Send.test.js.snap

Loading...
View Options

cashtab/src/components/Send/__tests__/__snapshots__/SendToken.test.js.snap

Loading...
View Options

cashtab/src/components/SignVerifyMsg/__tests__/__snapshots__/SignVerifyMsg.test.js.snap

Loading...
View Options

cashtab/src/components/Tokens/__tests__/__snapshots__/CreateTokenForm.test.js.snap

Loading...
View Options

cashtab/src/components/Tokens/__tests__/__snapshots__/Tokens.test.js.snap

Loading...