Page MenuHomePhabricator

[herald] Move non-config constants to separate file
ClosedPublic

Authored by bytesofman on May 24 2023, 20:09.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCf083ffe042ce: [herald] Move non-config constants to separate file
Summary

T2972

Following feedback from D13875, creating a separate constants.js file to hold constant values that are not related to config.

Test Plan

npm test

Diff Detail

Repository
rABC Bitcoin ABC
Branch
herald-move-miners-to-other-file
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 23784
Build 47178: Build Diffecash-herald-tests
Build 47177: arc lint + arc unit

Event Timeline

Fabien requested changes to this revision.May 25 2023, 12:38
Fabien added a subscriber: Fabien.
Fabien added inline comments.
apps/ecash-herald/constants.js
62

OK on the concept, but constants.js is not really self-explanatory and the miners are not related to layer apps.
I suggest you put them in separated files in the same constants directory, e.g. constants/miners.js and constants/op_return.js.

This revision now requires changes to proceed.May 25 2023, 12:38

Better folder organizing for constants

This revision is now accepted and ready to land.May 25 2023, 20:05