Paths

Table of Contentst

Differential D13942

build: Remove spaces from variable-printing rules
ClosedPublic
Actions

Authored by PiRK on May 26 2023, 09:17.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC3e0e9af88f7c: build: Remove spaces from variable-printing rules

Summary

This simplifies parsing when using these rules from scripts.

This is a backport of core#21304
https://github.com/bitcoin/bitcoin/pull/21304/commits/84912d4b24382ae022da3a863bd6caa2b8948d94

I was wondering why I had to add this space to find the SDK, when I initially tested guix.

Test Plan

With the Apple SDK in the expected directory:

HOSTS=x86_64-apple-darwin contrib/guix/guix-build

Check that it does not fail early because of not finding the SDK.

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.May 26 2023, 09:17

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 26 2023, 09:17

PiRK requested review of this revision.May 26 2023, 09:17

teamcity edited the summary of this revision. (Show Details)May 26 2023, 09:17

Harbormaster completed remote builds in B23809: Diff 40449.May 26 2023, 09:17

PiRK edited the test plan for this revision. (Show Details)May 26 2023, 09:34

Fabien accepted this revision.May 26 2023, 12:54

This revision is now accepted and ready to land.May 26 2023, 12:54

PiRK added a child revision: D13943: replace $(AT) with .SILENCE..May 26 2023, 13:07

Closed by commit rABC3e0e9af88f7c: build: Remove spaces from variable-printing rules (authored by Carl Dong <contact@carldong.me>, committed by PiRK). · Explain WhyMay 26 2023, 14:30

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC3e0e9af88f7c: build: Remove spaces from variable-printing rules.

Revision Contents
Changeset List

Path

Size

contrib/

guix/

guix-build

2 lines

depends/

Makefile

2 lines

Diff 40460

View Options

contrib/guix/guix-build