The limits are no longer enforced since the wellington activation, so the code is now dead code.
Details
Details
- Reviewers
PiRK - Group Reviewers
Restricted Project - Commits
- rABC04ab438c1676: Remove the mempool chained txs limit checks when calculating a tx ancestors
ninja all check-all
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- remove_wellington_constants
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 23878 Build 47366: Build Diff lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang Build 47365: arc lint + arc unit
Event Timeline
Comment Actions
Build Bitcoin ABC Diffs / Diff Testing (build-clang) failed.
Tail of the build log:
[372/539] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockfilter.cpp.o
[373/539] Building CXX object src/wallet/CMakeFiles/wallet-tool.dir/wallettool.cpp.o
[374/539] Building CXX object src/wallet/CMakeFiles/wallet.dir/bdb.cpp.o
[375/539] Building CXX object src/test/CMakeFiles/testutil.dir/util/wallet.cpp.o
[376/539] Building CXX object src/wallet/CMakeFiles/wallet.dir/context.cpp.o
[377/539] Building CXX object src/wallet/CMakeFiles/wallet.dir/coinselection.cpp.o
[378/539] Building CXX object src/CMakeFiles/server.dir/validation.cpp.o
FAILED: src/CMakeFiles/server.dir/validation.cpp.o
/usr/bin/ccache /usr/bin/clang++ -DBOOST_AC_USE_STD_ATOMIC -DBOOST_ALL_NO_LIB -DBOOST_SP_USE_STD_ATOMIC -DBUILD_BITCOIN_INTERNAL -DENABLE_AVX2 -DENABLE_SHANI -DENABLE_SSE41 -DHAVE_BUILD_INFO -DHAVE_CONFIG_H -DHAVE_CONSENSUS_LIB -DLEVELDB_ATOMIC_PRESENT -DLEVELDB_PLATFORM_POSIX -DOS_LINUX -I../../src/leveldb/helpers/memenv -I../../src/. -Isrc -I../../src/univalue/include -Isrc/crypto/.. -I../../src/secp256k1/include -I../../src/leveldb/include -isystem /usr/include/jemalloc -isystem /usr/include/miniupnpc -Werror -g -O2 -fPIC -fvisibility=hidden -fstack-protector-all -Wstack-protector -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Wall -Wextra -Wformat -Wgnu -Wvla -Wcast-align -Wunused-parameter -Wmissing-braces -Wthread-safety -Wrange-loop-analysis -Wredundant-decls -Wunreachable-code-loop-increment -Wsign-compare -Wconditional-uninitialized -Wdocumentation -Wformat-security -Wredundant-move -Woverloaded-virtual -Wshadow -Wshadow-field -Wno-unused-parameter -Wno-implicit-fallthrough -Wno-psabi -pthread -std=gnu++17 -MD -MT src/CMakeFiles/server.dir/validation.cpp.o -MF src/CMakeFiles/server.dir/validation.cpp.o.d -o src/CMakeFiles/server.dir/validation.cpp.o -c ../../src/validation.cpp
../../src/validation.cpp:493:18: error: private field 'm_limit_ancestors' is not used [-Werror,-Wunused-private-field]
const size_t m_limit_ancestors;
^
../../src/validation.cpp:494:18: error: private field 'm_limit_ancestor_size' is not used [-Werror,-Wunused-private-field]
const size_t m_limit_ancestor_size;
^
../../src/validation.cpp:497:12: error: private field 'm_limit_descendants' is not used [-Werror,-Wunused-private-field]
size_t m_limit_descendants;
^
../../src/validation.cpp:498:12: error: private field 'm_limit_descendant_size' is not used [-Werror,-Wunused-private-field]
size_t m_limit_descendant_size;
^
4 errors generated.
[379/539] Building CXX object src/wallet/CMakeFiles/wallet.dir/coincontrol.cpp.o
[380/539] Building CXX object src/wallet/CMakeFiles/wallet.dir/db.cpp.o
[381/539] Building CXX object src/test/CMakeFiles/testutil.dir/util/mining.cpp.o
[382/539] Building CXX object src/CMakeFiles/server.dir/torcontrol.cpp.o
[383/539] Building CXX object src/wallet/CMakeFiles/wallet.dir/crypter.cpp.o
[384/539] Building CXX object src/test/CMakeFiles/testutil.dir/util/net.cpp.o
[385/539] Building CXX object src/wallet/CMakeFiles/wallet.dir/interfaces.cpp.o
[386/539] Building CXX object src/wallet/CMakeFiles/wallet.dir/load.cpp.o
[387/539] Building CXX object src/wallet/CMakeFiles/wallet.dir/receive.cpp.o
[388/539] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcwallet.cpp.o
[389/539] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/backup.cpp.o
[390/539] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/encrypt.cpp.o
[391/539] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/util.cpp.o
[392/539] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/signmessage.cpp.o
[393/539] Building CXX object src/wallet/CMakeFiles/wallet.dir/sqlite.cpp.o
[394/539] Building CXX object src/wallet/CMakeFiles/wallet.dir/scriptpubkeyman.cpp.o
[395/539] Building CXX object src/wallet/CMakeFiles/wallet.dir/salvage.cpp.o
[396/539] Building CXX object src/test/CMakeFiles/testutil.dir/util/validation.cpp.o
[397/539] Building CXX object src/wallet/CMakeFiles/wallet.dir/spend.cpp.o
[398/539] Building CXX object src/CMakeFiles/server.dir/wallet/init.cpp.o
[399/539] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/dns.cpp.o
[400/539] Building CXX object src/wallet/CMakeFiles/wallet.dir/transaction.cpp.o
[401/539] Building CXX object src/CMakeFiles/server.dir/txmempool.cpp.o
[402/539] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/db.cpp.o
[403/539] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/options.cpp.o
[404/539] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletutil.cpp.o
[405/539] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o
[406/539] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletdb.cpp.o
[407/539] Building CXX object src/CMakeFiles/server.dir/rpc/rawtransaction.cpp.o
[408/539] Building CXX object src/wallet/CMakeFiles/wallet.dir/fees.cpp.o
[409/539] Building CXX object src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o
[410/539] Building CXX object src/CMakeFiles/server.dir/rpc/blockchain.cpp.o
[411/539] Building CXX object src/CMakeFiles/server.dir/net_processing.cpp.o
[412/539] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o
[413/539] Building CXX object src/wallet/CMakeFiles/wallet.dir/wallet.cpp.o
[414/539] Linking CXX static library src/wallet/libwallet.a
ninja: build stopped: cannot make progress due to previous errors.
Build build-clang failed with exit code 1