Make `node::BroadcastTransaction` take `const NodeContext &`, remove unused `Config` param
ClosedPublic
Actions

Authored by tobias_ruck on Jun 4 2023, 18:52.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCf3417a659fc3: Make `node::BroadcastTransaction` take `const NodeContext &`, remove unused…

Summary

This helps with broadcasting txs from Chronik, which only has a const NodeContext & and no const Config &. Broadcasting from Chronik becomes more important once SLP is added.

Currently BroadcastTransaction takes a mutable NodeContext &, however, the mutability is not required by any of the functions called on it. It also takes a const Config & param, but that is unused, so we remove it.

Making it const is still thread safe as BroadcastTransaction takes a LOCK(cs_main), and RelayTransaction (which isn't covered by that lock) has an internal per-node lock (see CNode::PushTxInventory and PeerManagerImpl::RelayTransaction).

Test Plan

ninja check-functional

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tobias_ruck created this revision.Jun 4 2023, 18:52

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 4 2023, 18:52

tobias_ruck requested review of this revision.Jun 4 2023, 18:52

Harbormaster completed remote builds in B23890: Diff 40578.Jun 4 2023, 19:09

Build Bitcoin ABC Diffs / Diff Testing (build-diff) failed.

Tail of the build log:

[0m[0;32mwallet_encryption.py --descriptors        | ✓ Passed  | 5 s
[0m[0;32mwallet_groups.py                          | ✓ Passed  | 11 s
[0m[0;32mwallet_hd.py                              | ✓ Passed  | 5 s
[0m[0;32mwallet_hd.py --descriptors                | ✓ Passed  | 5 s
[0m[0;32mwallet_import_rescan.py                   | ✓ Passed  | 6 s
[0m[0;32mwallet_import_with_label.py               | ✓ Passed  | 1 s
[0m[0;32mwallet_importdescriptors.py               | ✓ Passed  | 3 s
[0m[0;32mwallet_importmulti.py                     | ✓ Passed  | 3 s
[0m[0;32mwallet_importprunedfunds.py               | ✓ Passed  | 2 s
[0m[0;32mwallet_importprunedfunds.py --descriptors | ✓ Passed  | 1 s
[0m[0;32mwallet_keypool.py                         | ✓ Passed  | 3 s
[0m[0;32mwallet_keypool_topup.py                   | ✓ Passed  | 3 s
[0m[0;32mwallet_keypool_topup.py --descriptors     | ✓ Passed  | 3 s
[0m[0;32mwallet_labels.py                          | ✓ Passed  | 2 s
[0m[0;32mwallet_labels.py --descriptors            | ✓ Passed  | 1 s
[0m[0;32mwallet_listreceivedby.py                  | ✓ Passed  | 5 s
[0m[0;32mwallet_listsinceblock.py                  | ✓ Passed  | 5 s
[0m[0;32mwallet_listsinceblock.py --descriptors    | ✓ Passed  | 3 s
[0m[0;32mwallet_listtransactions.py                | ✓ Passed  | 4 s
[0m[0;32mwallet_listtransactions.py --descriptors  | ✓ Passed  | 3 s
[0m[0;32mwallet_multiwallet.py                     | ✓ Passed  | 39 s
[0m[0;32mwallet_multiwallet.py --usecli            | ✓ Passed  | 9 s
[0m[0;32mwallet_reorgsrestore.py                   | ✓ Passed  | 3 s
[0m[0;32mwallet_resendwallettransactions.py        | ✓ Passed  | 2 s
[0m[0;32mwallet_send.py                            | ✓ Passed  | 6 s
[0m[0;32mwallet_startup.py                         | ✓ Passed  | 2 s
[0m[0;32mwallet_timelock.py                        | ✓ Passed  | 1 s
[0m[0;32mwallet_txn_clone.py                       | ✓ Passed  | 1 s
[0m[0;32mwallet_txn_clone.py --mineblock           | ✓ Passed  | 2 s
[0m[0;32mwallet_txn_doublespend.py                 | ✓ Passed  | 1 s
[0m[0;32mwallet_txn_doublespend.py --mineblock     | ✓ Passed  | 2 s
[0m[0;32mwallet_watchonly.py                       | ✓ Passed  | 1 s
[0m[0;32mwallet_watchonly.py --usecli              | ✓ Passed  | 1 s
[0m[1;30mchronik_avalanche.py                      | ○ Skipped | 0 s
[0m[1;30mchronik_block.py                          | ○ Skipped | 0 s
[0m[1;30mchronik_block_info.py                     | ○ Skipped | 0 s
[0m[1;30mchronik_block_txs.py                      | ○ Skipped | 0 s
[0m[1;30mchronik_blockchain_info.py                | ○ Skipped | 0 s
[0m[1;30mchronik_blocks.py                         | ○ Skipped | 0 s
[0m[1;30mchronik_disallow_prune.py                 | ○ Skipped | 0 s
[0m[1;30mchronik_raw_tx.py                         | ○ Skipped | 0 s
[0m[1;30mchronik_resync.py                         | ○ Skipped | 0 s
[0m[1;30mchronik_script_confirmed_txs.py           | ○ Skipped | 0 s
[0m[1;30mchronik_script_history.py                 | ○ Skipped | 0 s
[0m[1;30mchronik_script_unconfirmed_txs.py         | ○ Skipped | 0 s
[0m[1;30mchronik_script_utxos.py                   | ○ Skipped | 0 s
[0m[1;30mchronik_serve.py                          | ○ Skipped | 0 s
[0m[1;30mchronik_spent_by.py                       | ○ Skipped | 0 s
[0m[1;30mchronik_tx.py                             | ○ Skipped | 0 s
[0m[1;30mchronik_ws.py                             | ○ Skipped | 0 s
[0m[1;30mchronik_ws_script.py                      | ○ Skipped | 0 s
[0m[1;30minterface_usdt_net.py                     | ○ Skipped | 0 s
[0m[1;30minterface_usdt_utxocache.py               | ○ Skipped | 0 s
[0m[1;30minterface_usdt_validation.py              | ○ Skipped | 0 s
[0m[1m
ALL                                       | ✓ Passed  | 1206 s (accumulated) 
[0mRuntime: 242 s

ninja: build stopped: cannot make progress due to previous errors.
Build build-diff failed with exit code 1

rerun tests

also remove the unused Config parameter

tobias_ruck retitled this revision from Make `node::BroadcastTransaction` take `const NodeContext &` to Make `node::BroadcastTransaction` take `const NodeContext &`, remove unused `Config` param.Jun 4 2023, 19:23

tobias_ruck edited the summary of this revision. (Show Details)

Harbormaster completed remote builds in B23893: Diff 40581.Jun 4 2023, 19:38

Harbormaster completed remote builds in B23892: Diff 40580.Jun 4 2023, 19:45

tobias_ruck added a child revision: D13982: [Chronik] Add `broadcast_tx` to `ChronikBridge`.Jun 4 2023, 22:09

Fabien accepted this revision.Jun 5 2023, 08:08

This revision is now accepted and ready to land.Jun 5 2023, 08:08

Closed by commit rABCf3417a659fc3: Make `node::BroadcastTransaction` take `const NodeContext &`, remove unused… (authored by tobias_ruck). · Explain WhyJun 5 2023, 09:33

This revision was automatically updated to reflect the committed changes.

tobias_ruck added a commit: rABCf3417a659fc3: Make `node::BroadcastTransaction` take `const NodeContext &`, remove unused….