Paths

Table of Contentst

Differential D13988

Add time helpers for std::chrono::steady_clock, Remove unused GetTimeSeconds
ClosedPublic
Actions

Authored by PiRK on Jun 5 2023, 12:12.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC13643e75537e: Add time helpers for std::chrono::steady_clock, Remove unused GetTimeSeconds

Summary

Add time helpers for std::chrono::steady_clock

random: Add FastRandomContext::rand_uniform_delay

Remove unused GetTimeSeconds

Seems confusing to have this helper when it is possible to get the system time in a type-safe way by simply calling std::chrono::system_clock::now (C++11).

This patch replaces GetTimeSeconds and removes it:

in bitcoin-cli.cpp by system_clock

in test/fuzz/fuzz.cpp by steady_clock

This is a backport of core#24921 and core#25102

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Jun 5 2023, 12:12

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 5 2023, 12:12

PiRK requested review of this revision.Jun 5 2023, 12:12

teamcity edited the summary of this revision. (Show Details)Jun 5 2023, 12:12

PiRK added a child revision: D13989: refactor: move Boost datetime usage to wallet.Jun 5 2023, 12:14

Harbormaster completed remote builds in B23902: Diff 40594.Jun 5 2023, 12:29

Fabien requested changes to this revision.Jun 5 2023, 17:01

Fabien added a subscriber: Fabien.

Fabien added inline comments.

src/bitcoin-cli.cpp
30 ↗	(On Diff #40594)	Revert, they were at the right place before
src/util/time.h
90 ↗	(On Diff #40594)
91 ↗	(On Diff #40594)

This revision now requires changes to proceed.Jun 5 2023, 17:01

revert moving of includes

and fix spelling in doxyxgn comment

Harbormaster completed remote builds in B23910: Diff 40603.Jun 5 2023, 21:21

Harbormaster completed remote builds in B23911: Diff 40604.

Fabien accepted this revision.Jun 6 2023, 05:52

Fabien added inline comments.

src/bitcoin-cli.cpp
26 ↗	(On Diff #40604)	Moving this one was correct, but that's the only one

This revision is now accepted and ready to land.Jun 6 2023, 05:52

move compat/stdin.h to internal includes

Harbormaster completed remote builds in B23919: Diff 40617.Jun 6 2023, 08:36

Closed by commit rABC13643e75537e: Add time helpers for std::chrono::steady_clock, Remove unused GetTimeSeconds (authored by MarcoFalke <falke.marco@gmail.com>, committed by PiRK). · Explain WhyJun 7 2023, 06:01

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC13643e75537e: Add time helpers for std::chrono::steady_clock, Remove unused GetTimeSeconds.

Revision Contents
Changeset List

Path

Size

src/

bitcoin-cli.cpp

9 lines

13 lines

test/

random_tests.cpp

26 lines

15 lines

util/

37 lines

4 lines

Diff 40634

src/bitcoin-cli.cpp

Loading...

src/random.h

Loading...

src/test/random_tests.cpp

Loading...

src/test/util_tests.cpp

Loading...

src/util/time.h

Loading...

src/util/time.cpp

Loading...