This is necessary when doing the native build on Mac OS, but it breaks the native build when cross-compiling, so keep it disable for the latter.
Details
Details
- Reviewers
Fabien - Group Reviewers
Restricted Project
cmake .. -GNinja && ninja on Linux and Mac OS
guix build
CI crossbuilds
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- check_boost_version
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 23937 Build 47484: Build Diff lint-circular-dependencies · build-debug · build-without-wallet · build-clang-tidy · build-clang · build-diff Build 47483: arc lint + arc unit
Event Timeline
Comment Actions
it does not work for guix
I also tried
if(NOT CMAKE_CROSSCOMPILING) find_package(Boost 1.64 REQUIRED) endif()
with the same result:
CMake Error at /gnu/store/nvqiq707xrc3blc044l9mpaazj5fi911-cmake-3.21.4/share/cmake-3.21/Modules/FindPackageHandleStandardArgs.cmake:230 (message): Could NOT find Boost (missing: Boost_INCLUDE_DIR) (Required is at least version "1.64") Call Stack (most recent call first): /gnu/store/nvqiq707xrc3blc044l9mpaazj5fi911-cmake-3.21.4/share/cmake-3.21/Modules/FindPackageHandleStandardArgs.cmake:594 (_FPHSA_FAILURE_MESSAGE) /gnu/store/nvqiq707xrc3blc044l9mpaazj5fi911-cmake-3.21.4/share/cmake-3.21/Modules/FindBoost.cmake:2360 (find_package_handle_standard_args) src/CMakeLists.txt:475 (find_package)
And
if(NOT CMAKE_CROSSCOMPILING) find_package(Boost 1.64 COMPONENTS headers REQUIRED) endif()
causes this error:
CMake Warning at /gnu/store/nvqiq707xrc3blc044l9mpaazj5fi911-cmake-3.21.4/share/cmake-3.21/Modules/FindBoost.cmake:2201 (message): No header defined for headers; skipping header check (note: header-only libraries have no designated component) Call Stack (most recent call first): src/CMakeLists.txt:475 (find_package) CMake Error at /gnu/store/nvqiq707xrc3blc044l9mpaazj5fi911-cmake-3.21.4/share/cmake-3.21/Modules/FindPackageHandleStandardArgs.cmake:230 (message): Could NOT find Boost (missing: Boost_INCLUDE_DIR headers) (Required is at least version "1.64")
Comment Actions
Build Bitcoin ABC Diffs / Diff Testing (gitian-osx) failed.
Tail of the build log:
* [new tag] phabricator/diff/40514 -> phabricator/diff/40514 * [new tag] phabricator/diff/40525 -> phabricator/diff/40525 * [new tag] phabricator/diff/40526 -> phabricator/diff/40526 * [new tag] phabricator/diff/40527 -> phabricator/diff/40527 * [new tag] phabricator/diff/40529 -> phabricator/diff/40529 * [new tag] phabricator/diff/40541 -> phabricator/diff/40541 * [new tag] phabricator/diff/40542 -> phabricator/diff/40542 * [new tag] phabricator/diff/40543 -> phabricator/diff/40543 * [new tag] phabricator/diff/40544 -> phabricator/diff/40544 * [new tag] phabricator/diff/40551 -> phabricator/diff/40551 * [new tag] phabricator/diff/40552 -> phabricator/diff/40552 * [new tag] phabricator/diff/40559 -> phabricator/diff/40559 * [new tag] phabricator/diff/40560 -> phabricator/diff/40560 * [new tag] phabricator/diff/40561 -> phabricator/diff/40561 * [new tag] phabricator/diff/40562 -> phabricator/diff/40562 * [new tag] phabricator/diff/40563 -> phabricator/diff/40563 * [new tag] phabricator/diff/40564 -> phabricator/diff/40564 * [new tag] phabricator/diff/40578 -> phabricator/diff/40578 * [new tag] phabricator/diff/40579 -> phabricator/diff/40579 * [new tag] phabricator/diff/40580 -> phabricator/diff/40580 * [new tag] phabricator/diff/40581 -> phabricator/diff/40581 * [new tag] phabricator/diff/40583 -> phabricator/diff/40583 * [new tag] phabricator/diff/40585 -> phabricator/diff/40585 * [new tag] phabricator/diff/40589 -> phabricator/diff/40589 * [new tag] phabricator/diff/40590 -> phabricator/diff/40590 * [new tag] phabricator/diff/40591 -> phabricator/diff/40591 * [new tag] phabricator/diff/40594 -> phabricator/diff/40594 * [new tag] phabricator/diff/40595 -> phabricator/diff/40595 * [new tag] phabricator/diff/40597 -> phabricator/diff/40597 * [new tag] phabricator/diff/40598 -> phabricator/diff/40598 * [new tag] phabricator/diff/40599 -> phabricator/diff/40599 * [new tag] phabricator/diff/40603 -> phabricator/diff/40603 * [new tag] phabricator/diff/40604 -> phabricator/diff/40604 * [new tag] phabricator/diff/40606 -> phabricator/diff/40606 * [new tag] phabricator/diff/40618 -> phabricator/diff/40618 * [new tag] phabricator/diff/8992 -> phabricator/diff/8992 * [new tag] phabricator/diff/8993 -> phabricator/diff/8993 * [new branch] master -> master --- Building for bullseye amd64 --- Stopping target if it is up Error response from daemon: No such container: gitian-target Error: No such container: gitian-target Making a new image copy Starting target Checking if target is up. Preparing build environment Updating apt-get repository (log in var/install.log) Installing additional packages (log in var/install.log) Upgrading system, may take a while (log in var/install.log) Creating package manifest Creating build script (var/build-script) Running build script (log in var/build.log) ./bin/gbuild:23:in `system!': failed to run on-target setarch x86_64 bash -x < var/build-script > var/build.log 2>&1 (RuntimeError) from ./bin/gbuild:185:in `build_one_configuration' from ./bin/gbuild:339:in `block (2 levels) in <main>' from ./bin/gbuild:334:in `each' from ./bin/gbuild:334:in `block in <main>' from ./bin/gbuild:332:in `each' from ./bin/gbuild:332:in `<main>' Build gitian-osx failed with exit code 1
| src/CMakeLists.txt | ||
|---|---|---|
| 479 ↗ | (On Diff #40635) | There is no reason this only applies to darwin targets. |
Comment Actions
Build Bitcoin ABC Diffs / Diff Testing (gitian-win) failed.
Tail of the build log:
* [new tag] phabricator/diff/40542 -> phabricator/diff/40542 * [new tag] phabricator/diff/40543 -> phabricator/diff/40543 * [new tag] phabricator/diff/40547 -> phabricator/diff/40547 * [new tag] phabricator/diff/40551 -> phabricator/diff/40551 * [new tag] phabricator/diff/40552 -> phabricator/diff/40552 * [new tag] phabricator/diff/40553 -> phabricator/diff/40553 * [new tag] phabricator/diff/40554 -> phabricator/diff/40554 * [new tag] phabricator/diff/40558 -> phabricator/diff/40558 * [new tag] phabricator/diff/40559 -> phabricator/diff/40559 * [new tag] phabricator/diff/40560 -> phabricator/diff/40560 * [new tag] phabricator/diff/40561 -> phabricator/diff/40561 * [new tag] phabricator/diff/40562 -> phabricator/diff/40562 * [new tag] phabricator/diff/40563 -> phabricator/diff/40563 * [new tag] phabricator/diff/40564 -> phabricator/diff/40564 * [new tag] phabricator/diff/40578 -> phabricator/diff/40578 * [new tag] phabricator/diff/40579 -> phabricator/diff/40579 * [new tag] phabricator/diff/40580 -> phabricator/diff/40580 * [new tag] phabricator/diff/40581 -> phabricator/diff/40581 * [new tag] phabricator/diff/40582 -> phabricator/diff/40582 * [new tag] phabricator/diff/40583 -> phabricator/diff/40583 * [new tag] phabricator/diff/40584 -> phabricator/diff/40584 * [new tag] phabricator/diff/40590 -> phabricator/diff/40590 * [new tag] phabricator/diff/40591 -> phabricator/diff/40591 * [new tag] phabricator/diff/40594 -> phabricator/diff/40594 * [new tag] phabricator/diff/40597 -> phabricator/diff/40597 * [new tag] phabricator/diff/40599 -> phabricator/diff/40599 * [new tag] phabricator/diff/40600 -> phabricator/diff/40600 * [new tag] phabricator/diff/40603 -> phabricator/diff/40603 * [new tag] phabricator/diff/40604 -> phabricator/diff/40604 * [new tag] phabricator/diff/40605 -> phabricator/diff/40605 * [new tag] phabricator/diff/40612 -> phabricator/diff/40612 * [new tag] phabricator/diff/40635 -> phabricator/diff/40635 * [new tag] phabricator/diff/40637 -> phabricator/diff/40637 * [new tag] phabricator/diff/40639 -> phabricator/diff/40639 * [new tag] phabricator/diff/40641 -> phabricator/diff/40641 * [new tag] phabricator/diff/8992 -> phabricator/diff/8992 * [new tag] phabricator/diff/8993 -> phabricator/diff/8993 * [new branch] master -> master --- Building for bullseye amd64 --- Stopping target if it is up Error response from daemon: No such container: gitian-target Error: No such container: gitian-target Making a new image copy Starting target Checking if target is up... Preparing build environment Updating apt-get repository (log in var/install.log) Installing additional packages (log in var/install.log) Upgrading system, may take a while (log in var/install.log) Creating package manifest Creating build script (var/build-script) Running build script (log in var/build.log) ./bin/gbuild:23:in `system!': failed to run on-target setarch x86_64 bash -x < var/build-script > var/build.log 2>&1 (RuntimeError) from ./bin/gbuild:185:in `build_one_configuration' from ./bin/gbuild:339:in `block (2 levels) in <main>' from ./bin/gbuild:334:in `each' from ./bin/gbuild:334:in `block in <main>' from ./bin/gbuild:332:in `each' from ./bin/gbuild:332:in `<main>' Build gitian-win failed with exit code 1
Comment Actions
Build Bitcoin ABC Diffs / Diff Testing (gitian-osx) failed.
Tail of the build log:
* [new tag] phabricator/diff/40540 -> phabricator/diff/40540 * [new tag] phabricator/diff/40541 -> phabricator/diff/40541 * [new tag] phabricator/diff/40542 -> phabricator/diff/40542 * [new tag] phabricator/diff/40543 -> phabricator/diff/40543 * [new tag] phabricator/diff/40544 -> phabricator/diff/40544 * [new tag] phabricator/diff/40551 -> phabricator/diff/40551 * [new tag] phabricator/diff/40552 -> phabricator/diff/40552 * [new tag] phabricator/diff/40553 -> phabricator/diff/40553 * [new tag] phabricator/diff/40558 -> phabricator/diff/40558 * [new tag] phabricator/diff/40559 -> phabricator/diff/40559 * [new tag] phabricator/diff/40560 -> phabricator/diff/40560 * [new tag] phabricator/diff/40561 -> phabricator/diff/40561 * [new tag] phabricator/diff/40562 -> phabricator/diff/40562 * [new tag] phabricator/diff/40563 -> phabricator/diff/40563 * [new tag] phabricator/diff/40564 -> phabricator/diff/40564 * [new tag] phabricator/diff/40578 -> phabricator/diff/40578 * [new tag] phabricator/diff/40579 -> phabricator/diff/40579 * [new tag] phabricator/diff/40583 -> phabricator/diff/40583 * [new tag] phabricator/diff/40584 -> phabricator/diff/40584 * [new tag] phabricator/diff/40585 -> phabricator/diff/40585 * [new tag] phabricator/diff/40594 -> phabricator/diff/40594 * [new tag] phabricator/diff/40595 -> phabricator/diff/40595 * [new tag] phabricator/diff/40597 -> phabricator/diff/40597 * [new tag] phabricator/diff/40598 -> phabricator/diff/40598 * [new tag] phabricator/diff/40599 -> phabricator/diff/40599 * [new tag] phabricator/diff/40603 -> phabricator/diff/40603 * [new tag] phabricator/diff/40605 -> phabricator/diff/40605 * [new tag] phabricator/diff/40617 -> phabricator/diff/40617 * [new tag] phabricator/diff/40618 -> phabricator/diff/40618 * [new tag] phabricator/diff/40625 -> phabricator/diff/40625 * [new tag] phabricator/diff/40628 -> phabricator/diff/40628 * [new tag] phabricator/diff/40629 -> phabricator/diff/40629 * [new tag] phabricator/diff/40632 -> phabricator/diff/40632 * [new tag] phabricator/diff/40633 -> phabricator/diff/40633 * [new tag] phabricator/diff/40637 -> phabricator/diff/40637 * [new tag] phabricator/diff/40640 -> phabricator/diff/40640 * [new tag] phabricator/diff/40641 -> phabricator/diff/40641 * [new tag] phabricator/diff/8992 -> phabricator/diff/8992 * [new tag] phabricator/diff/8993 -> phabricator/diff/8993 * [new branch] master -> master --- Building for bullseye amd64 --- Stopping target if it is up Making a new image copy Starting target Checking if target is up. Preparing build environment Updating apt-get repository (log in var/install.log) Installing additional packages (log in var/install.log) Upgrading system, may take a while (log in var/install.log) Creating package manifest Creating build script (var/build-script) Running build script (log in var/build.log) ./bin/gbuild:23:in `system!': failed to run on-target setarch x86_64 bash -x < var/build-script > var/build.log 2>&1 (RuntimeError) from ./bin/gbuild:185:in `build_one_configuration' from ./bin/gbuild:339:in `block (2 levels) in <main>' from ./bin/gbuild:334:in `each' from ./bin/gbuild:334:in `block in <main>' from ./bin/gbuild:332:in `each' from ./bin/gbuild:332:in `<main>' Build gitian-osx failed with exit code 1
Comment Actions
Build Bitcoin ABC Diffs / Diff Testing (gitian-linux) failed.
Tail of the build log:
* [new tag] phabricator/diff/40513 -> phabricator/diff/40513 * [new tag] phabricator/diff/40514 -> phabricator/diff/40514 * [new tag] phabricator/diff/40526 -> phabricator/diff/40526 * [new tag] phabricator/diff/40529 -> phabricator/diff/40529 * [new tag] phabricator/diff/40531 -> phabricator/diff/40531 * [new tag] phabricator/diff/40541 -> phabricator/diff/40541 * [new tag] phabricator/diff/40542 -> phabricator/diff/40542 * [new tag] phabricator/diff/40543 -> phabricator/diff/40543 * [new tag] phabricator/diff/40551 -> phabricator/diff/40551 * [new tag] phabricator/diff/40552 -> phabricator/diff/40552 * [new tag] phabricator/diff/40553 -> phabricator/diff/40553 * [new tag] phabricator/diff/40559 -> phabricator/diff/40559 * [new tag] phabricator/diff/40560 -> phabricator/diff/40560 * [new tag] phabricator/diff/40561 -> phabricator/diff/40561 * [new tag] phabricator/diff/40564 -> phabricator/diff/40564 * [new tag] phabricator/diff/40578 -> phabricator/diff/40578 * [new tag] phabricator/diff/40580 -> phabricator/diff/40580 * [new tag] phabricator/diff/40590 -> phabricator/diff/40590 * [new tag] phabricator/diff/40591 -> phabricator/diff/40591 * [new tag] phabricator/diff/40592 -> phabricator/diff/40592 * [new tag] phabricator/diff/40594 -> phabricator/diff/40594 * [new tag] phabricator/diff/40595 -> phabricator/diff/40595 * [new tag] phabricator/diff/40597 -> phabricator/diff/40597 * [new tag] phabricator/diff/40599 -> phabricator/diff/40599 * [new tag] phabricator/diff/40600 -> phabricator/diff/40600 * [new tag] phabricator/diff/40604 -> phabricator/diff/40604 * [new tag] phabricator/diff/40605 -> phabricator/diff/40605 * [new tag] phabricator/diff/40606 -> phabricator/diff/40606 * [new tag] phabricator/diff/40613 -> phabricator/diff/40613 * [new tag] phabricator/diff/40617 -> phabricator/diff/40617 * [new tag] phabricator/diff/40618 -> phabricator/diff/40618 * [new tag] phabricator/diff/40635 -> phabricator/diff/40635 * [new tag] phabricator/diff/40637 -> phabricator/diff/40637 * [new tag] phabricator/diff/40638 -> phabricator/diff/40638 * [new tag] phabricator/diff/40641 -> phabricator/diff/40641 * [new tag] phabricator/diff/8992 -> phabricator/diff/8992 * [new tag] phabricator/diff/8993 -> phabricator/diff/8993 * [new branch] master -> master --- Building for bullseye amd64 --- Stopping target if it is up Error response from daemon: No such container: gitian-target Error: No such container: gitian-target Making a new image copy Starting target Checking if target is up.. Preparing build environment Updating apt-get repository (log in var/install.log) Installing additional packages (log in var/install.log) Upgrading system, may take a while (log in var/install.log) Creating package manifest Creating build script (var/build-script) Running build script (log in var/build.log) ./bin/gbuild:23:in `system!': failed to run on-target setarch x86_64 bash -x < var/build-script > var/build.log 2>&1 (RuntimeError) from ./bin/gbuild:185:in `build_one_configuration' from ./bin/gbuild:339:in `block (2 levels) in <main>' from ./bin/gbuild:334:in `each' from ./bin/gbuild:334:in `block in <main>' from ./bin/gbuild:332:in `each' from ./bin/gbuild:332:in `<main>' Build gitian-linux failed with exit code 1