Differential D14009

Revert to finding and linking boost headers
ClosedPublic
Actions

Authored by Fabien on Jun 7 2023, 16:20.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABC2fcf9572de66: Revert to finding and linking boost headers

Summary

This will unbreak the macos build which requires to look up for the brew installation, and it is more correct for any build anyway as we can enforce the versioning.

Test Plan

Run the build on macOs
Run the gitian builds
Run the guix build
Run the build on linux

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Jun 7 2023, 16:20

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 7 2023, 16:20

Fabien requested review of this revision.Jun 7 2023, 16:20

@bot build-linux64 build-osx build-win64 gitian-linux gitian-osx gitian-win

teamcity awarded a token.Jun 7 2023, 16:21

Harbormaster completed remote builds in B23938: Diff 40642.Jun 7 2023, 16:36

PiRK accepted this revision.Jun 7 2023, 17:56

This revision is now accepted and ready to land.Jun 7 2023, 17:56

Closed by commit rABC2fcf9572de66: Revert to finding and linking boost headers (authored by Fabien). · Explain WhyJun 7 2023, 18:08

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC2fcf9572de66: Revert to finding and linking boost headers.

PiRK mentioned this in D13999: [build] check for boost 1.64 except for native build.Jun 8 2023, 05:39

Revision Contents
Changeset List

Path

Size

cmake/

modules/

NativeExecutable.cmake

13 lines

src/

CMakeLists.txt

6 lines

Diff 40649

View Options

cmake/modules/NativeExecutable.cmake