Page MenuHomePhabricator
Differential D14064

guix: use proper compiler in cmake toolchain
ClosedPublic
Actions

Authored by PiRK on Jun 15 2023, 12:55.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCdbafb58269e5: guix: use proper compiler in cmake toolchain
Summary

For some reason the -DCMAKE_BUILD_WITH_INSTALL_RPATH=ON is required on the first cmake command to avoid error messages.

Depends on D14065

Test Plan

contrib/guix/guix-build

Check that it now use the correct cross-compiler to compile Bitcoin ABC.

This is now almost working, down to one wrong symbol (pthread_sigmask) found by symbol-check in bitcoin-qt

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Jun 15 2023, 12:55
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 15 2023, 12:55
PiRK requested review of this revision.Jun 15 2023, 12:55
Harbormaster completed remote builds in B24051: Diff 40805.Jun 15 2023, 12:55
PiRK planned changes to this revision.Jun 15 2023, 13:00

this was meant to be a draft, just to have a remote backup of work-in-progress

PiRK updated this revision to Diff 40806.Jun 15 2023, 13:44

fix linter errors and fix CMAKE_CXX_COMPILER

PiRK planned changes to this revision.Jun 15 2023, 13:44
PiRK mentioned this in D14065: build, qt: Use mkspecs/bitcoin-linux-g++ for all Linux hosts.Jun 15 2023, 14:00
Harbormaster completed remote builds in B24052: Diff 40806.Jun 15 2023, 14:01
PiRK updated this revision to Diff 40808.Jun 15 2023, 14:29

rebase onto D14065

PiRK updated this revision to Diff 40809.Jun 15 2023, 14:31

remove useless debugging statement

PiRK edited the summary of this revision. (Show Details)Jun 15 2023, 14:32
PiRK edited the test plan for this revision. (Show Details)
PiRK added a parent revision: D14065: build, qt: Use mkspecs/bitcoin-linux-g++ for all Linux hosts.
Harbormaster completed remote builds in B24054: Diff 40808.Jun 15 2023, 14:42
Harbormaster completed remote builds in B24055: Diff 40809.Jun 15 2023, 14:53
Fabien requested changes to this revision.Jun 15 2023, 15:19
Fabien added a subscriber: Fabien.
Fabien added inline comments.
cmake/platforms/Linux64.cmake
13 ↗(On Diff #40809)

I would expect CROSS_GCC to hold the path to the GCC executable and not only the root directory.
From the cmake file point of view the name is wrong.

This revision now requires changes to proceed.Jun 15 2023, 15:19
PiRK updated this revision to Diff 40837.Jun 16 2023, 05:57

rename CROSS_GCC -> CROSS_GCC_ROOT
don't export it for mingw yet, wait until we deal with that toolchain.

Harbormaster completed remote builds in B24075: Diff 40837.Jun 16 2023, 06:14
PiRK edited the test plan for this revision. (Show Details)Jun 16 2023, 08:29
Fabien accepted this revision.Jun 16 2023, 12:58
This revision is now accepted and ready to land.Jun 16 2023, 12:58
Closed by commit rABCdbafb58269e5: guix: use proper compiler in cmake toolchain (authored by PiRK). · Explain WhyJun 16 2023, 13:01
This revision was automatically updated to reflect the committed changes.
PiRK mentioned this in rABCeb2336ad020b: build, qt: Use mkspecs/bitcoin-linux-g++ for all Linux hosts.
PiRK added a commit: rABCdbafb58269e5: guix: use proper compiler in cmake toolchain.

Revision Contents
Changeset List

PathSize
cmake/
platforms/
11 lines
contrib/
guix/
libexec/
12 lines

Diff 40839

View Options

cmake/platforms/Linux64.cmake

Loading...
View Options

contrib/guix/libexec/build.sh

Loading...