[ecash-herald] parse etoken burn txs
ClosedPublic
Actions

Authored by bytesofman on Jun 16 2023, 22:07.

Details

Reviewers

emack

Group Reviewers

Restricted Project

Commits

rABCc27e5eda683d: [ecash-herald] parse etoken burn txs

Summary

T3060

Parse etoken burn txs

Test Plan

npm test

Repository

rABC Bitcoin ABC

Branch

herald-parse-etoken-burns

Lint

Lint Passed

Unit

No Test Coverage

Build Status

bytesofman requested review of this revision.Jun 16 2023, 22:07

emack requested changes to this revision.Jun 17 2023, 12:02

emack added a subscriber: emack.

emack added inline comments.

apps/ecash-herald/src/parse.js
223	shouldn't this be the other way? i.e. if output token amount (rather than this input amount) is less than input token amount then the delta is the burn amount

This revision now requires changes to proceed.Jun 17 2023, 12:02

bytesofman requested review of this revision.Jun 17 2023, 16:27

bytesofman added inline comments.

apps/ecash-herald/src/parse.js
223	In this case, we are processing numbers provided by chronik, and not manually adding the input and output qty of the token tx to calculate a burn amount (though this info would be available in `tokenSendInfo`) chronik indexes burn amounts, so using those