Page MenuHomePhabricator
Differential D14078

[e.cash] Expand scope of linter to include other files and directories that should be linted
ClosedPublic
Actions

Authored by bytesofman on Jun 17 2023, 18:28.

Details

Reviewers
emack
Group Reviewers
Restricted Project
Commits
rABC647e5f0e6736: [e.cash] Expand scope of linter to include other files and directories that…
Summary

Depends on D14077

Add 'data' and 'styles' folders to eslint on top of nextjs default directories

Add top level files .eslintrc.js, next.config.js, and jest.config.js

Test Plan

@bot preview-e.cash still builds
npm run lint and no errors

Diff Detail

Repository
rABC Bitcoin ABC
Branch
e-dot-cash-header
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 24085
Build 47780: Build Diff
Build 47779: arc lint + arc unit

Event Timeline

bytesofman created this revision.Jun 17 2023, 18:28
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 17 2023, 18:28
bytesofman requested review of this revision.Jun 17 2023, 18:28
Harbormaster completed remote builds in B24083: Diff 40854.Jun 17 2023, 18:28
bytesofman updated this revision to Diff 40855.Jun 17 2023, 18:40

Expand scope of linter to include other files that should be linted

Harbormaster completed remote builds in B24084: Diff 40855.Jun 17 2023, 18:41
bytesofman retitled this revision from [e.cash] Patch IDE error from known lint issue to [e.cash] Expand scope of linter to include other files and directories that should be linted.Jun 17 2023, 18:41
bytesofman edited the summary of this revision. (Show Details)
bytesofman updated this revision to Diff 40856.Jun 17 2023, 18:42

remove attempt to patch other issue

Harbormaster completed remote builds in B24085: Diff 40856.Jun 17 2023, 18:42
bytesofman edited the summary of this revision. (Show Details)Jun 17 2023, 18:44
emack added a subscriber: emack.Jun 17 2023, 23:28

@bot preview-e.cash

teamcity awarded a token.Jun 17 2023, 23:28

Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://54.39.104.128:41488 for the next 60 minutes.

emack accepted this revision.Jun 17 2023, 23:32
This revision is now accepted and ready to land.Jun 17 2023, 23:32
Closed by commit rABC647e5f0e6736: [e.cash] Expand scope of linter to include other files and directories that… (authored by bytesofman). · Explain WhyJun 19 2023, 17:21
This revision was automatically updated to reflect the committed changes.
bytesofman added a commit: rABC647e5f0e6736: [e.cash] Expand scope of linter to include other files and directories that….

Revision Contents
Changeset List

PathSize
web/
e.cash/
data/
3 lines
3 lines
3 lines
3 lines
3 lines
17 lines
styles/
3 lines
pages/
3 lines
3 lines
3 lines
3 lines
3 lines
3 lines
3 lines

Diff 40856

View Options

web/e.cash/data/faqs.js

Loading...
View Options

web/e.cash/data/navitems.js

Loading...
View Options

web/e.cash/data/roadmap.js

Loading...
View Options

web/e.cash/data/socials.js

Loading...
View Options

web/e.cash/jest.config.js

Loading...
View Options

web/e.cash/next.config.js

Loading...
View Options

web/e.cash/styles/global.js

Loading...
View Options

web/e.cash/styles/pages/core-tech.js

Loading...
View Options

web/e.cash/styles/pages/ecash-brand.js

Loading...
View Options

web/e.cash/styles/pages/faq.js

Loading...
View Options

web/e.cash/styles/pages/get-ecash.js

Loading...
View Options

web/e.cash/styles/pages/homepage.js

Loading...
View Options

web/e.cash/styles/pages/wealth-redefined.js

Loading...
View Options

web/e.cash/styles/theme.js

Loading...