Page MenuHomePhabricator
Differential D14079

[ecash-herald] Format sent xec amounts
ClosedPublic
Actions

Authored by bytesofman on Jun 19 2023, 19:31.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Commits
rABCad04bbc9a7ab: [ecash-herald] Format sent xec amounts
Summary

T2972

Add a new function to convert satoshis to a formatted string appropriate for a msg.

Implement for normal XEC txs. Not implemented (yet) for encrypted cashtab msgs, airdrops, and fusions as these functions preferencially display fiat values if they have them. Will add here after adding a function to format fiat values.

Test Plan

npm test

Diff Detail

Repository
rABC Bitcoin ABC
Branch
format-xec-amounts-herald
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 24091
Build 47792: Build Diffecash-herald-tests
Build 47791: arc lint + arc unit

Event Timeline

bytesofman created this revision.Jun 19 2023, 19:31
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 19 2023, 19:31
bytesofman requested review of this revision.Jun 19 2023, 19:31
Harbormaster completed remote builds in B24091: Diff 40866.Jun 19 2023, 19:32
PiRK accepted this revision.Jun 19 2023, 20:14
PiRK added a subscriber: PiRK.
PiRK added inline comments.
apps/ecash-herald/test/utilsTests.js
200

nit: this example is not rounded

This revision is now accepted and ready to land.Jun 19 2023, 20:14
bytesofman updated this revision to Diff 40868.Jun 19 2023, 21:30

clarifying unit test, adding rounding example for trillions

bytesofman marked an inline comment as done.Jun 19 2023, 21:30
This revision was landed with ongoing or failed builds.Jun 19 2023, 21:31
Closed by commit rABCad04bbc9a7ab: [ecash-herald] Format sent xec amounts (authored by bytesofman). · Explain Why
This revision was automatically updated to reflect the committed changes.
bytesofman added a commit: rABCad04bbc9a7ab: [ecash-herald] Format sent xec amounts.
Harbormaster completed remote builds in B24093: Diff 40868.Jun 19 2023, 21:31
bytesofman mentioned this in D14080: [ecash-herald] display amounts in fiat if prices are available.Jun 19 2023, 22:18

Revision Contents
Changeset List

PathSize
apps/
ecash-herald/
src/
17 lines
47 lines
test/
mocks/
31 lines

Diff 40866

View Options

apps/ecash-herald/src/parse.js

Loading...
View Options

apps/ecash-herald/src/utils.js

Loading...
View Options

apps/ecash-herald/test/mocks/blocks.js

Loading...
View Options

apps/ecash-herald/test/utilsTests.js

Loading...