T2972
Add new function satsToFormattedFiat that accepts satoshis and coingeckoPrices and returns a formatted string. Returns amount in XEC if dollar amount is less than 1.
Details
Details
- Reviewers
emack - Group Reviewers
Restricted Project - Commits
- rABCfc608272413f: [ecash-herald] display amounts in fiat if prices are available
npm test
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- sats-to-formatted-fiat
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 24095 Build 47800: Build Diff ecash-herald-tests Build 47799: arc lint + arc unit
Event Timeline
| apps/ecash-herald/test/utilsTests.js | ||
|---|---|---|
| 35 | it's weird that these unrelated MockAdapter lines got this treatment I tried going back to master and prettier --write test/utilsTests.js but no effect. So, these changes are somehow related to this file getting longer with other unit tests. Weirder still that this didn't happen in D14079 | |
| apps/ecash-herald/src/utils.js | ||
|---|---|---|
| 173 ↗ | (On Diff #40872) | since you already worked out xecAmount above then just use that instead of calling satsToformattedXec |
| apps/ecash-herald/test/utilsTests.js | ||
| 261 ↗ | (On Diff #40872) | can use another test for a fiat amount that is close to $999,999.99 and see if there are any rounding errors that would result in the M descriptor being incorrectly assigned as opposed to K. |