Paths

Table of Contentst

Differential D14082

[ecash-herald] patch bug in satsToFormattedXec
ClosedPublic
Actions

Authored by bytesofman on Jun 19 2023, 22:28.

Details

Reviewers

emack

Group Reviewers

Restricted Project

Commits

rABC422c39df7633: [ecash-herald] patch bug in satsToFormattedXec

Summary

T2972

Depends on D14081

Add >= to make sure there isn't a blind spot in coverage of formatted values. Add unit test to confirm.

Test Plan

npm test

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 24107
Build 47824: Build Diff	ecash-herald-tests
Build 47823: arc lint + arc unit

Event Timeline

bytesofman created this revision.Jun 19 2023, 22:28

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 19 2023, 22:28

bytesofman requested review of this revision.Jun 19 2023, 22:28

Harbormaster completed remote builds in B24098: Diff 40874.Jun 19 2023, 22:29

bytesofman added a child revision: D14083: [ecash-herald] Remove hardcoded string from function.Jun 19 2023, 22:30

emack accepted this revision.Jun 19 2023, 23:28

This revision is now accepted and ready to land.Jun 19 2023, 23:28

rebase

Harbormaster completed remote builds in B24107: Diff 40885.Jun 19 2023, 23:52

Closed by commit rABC422c39df7633: [ecash-herald] patch bug in satsToFormattedXec (authored by bytesofman). · Explain WhyJun 20 2023, 16:07

This revision was automatically updated to reflect the committed changes.

bytesofman added a commit: rABC422c39df7633: [ecash-herald] patch bug in satsToFormattedXec.

Revision Contents
Changeset List

Path

Size

apps/

ecash-herald/

src/

utils.js

2 lines

test/

utilsTests.js

6 lines

Diff 40885

View Options

apps/ecash-herald/src/utils.js