Paths

Table of Contentst

Differential D14085

[ecash-herald] Clean up comments for fusion tx parsing
ClosedPublic
Actions

Authored by bytesofman on Jun 19 2023, 23:01.

Details

Reviewers

emack

Group Reviewers

Restricted Project

Commits

rABC5bb14d105cf1: [ecash-herald] Clean up comments for fusion tx parsing

Summary

T2972

Depends on D14083

Remove unhelpful comment made with wrong format

Test Plan

npm test

Diff Detail

Repository

rABC Bitcoin ABC

Branch

sats-to-formatted-fiat

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 24102
Build 47814: Build Diff	ecash-herald-tests
Build 47813: arc lint + arc unit

Event Timeline

bytesofman created this revision.Jun 19 2023, 23:01

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 19 2023, 23:01

bytesofman requested review of this revision.Jun 19 2023, 23:01

Harbormaster completed remote builds in B24102: Diff 40879.Jun 19 2023, 23:04

rebase

Harbormaster completed remote builds in B24109: Diff 40887.Jun 19 2023, 23:54

emack accepted this revision.Jun 20 2023, 00:01

This revision is now accepted and ready to land.Jun 20 2023, 00:01

Closed by commit rABC5bb14d105cf1: [ecash-herald] Clean up comments for fusion tx parsing (authored by bytesofman). · Explain WhyJun 20 2023, 16:07

This revision was automatically updated to reflect the committed changes.

bytesofman added a commit: rABC5bb14d105cf1: [ecash-herald] Clean up comments for fusion tx parsing.

Revision Contents
Changeset List

Path

Size

apps/

ecash-herald/

src/

parse.js

6 lines

Diff 40879

View Options

apps/ecash-herald/src/parse.js

[ecash-herald] Clean up comments for fusion tx parsingClosedPublicActions