[e.cash] Add mining section
ClosedPublic
Actions

Authored by johnkuney on Jun 21 2023, 21:41.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC063e03dc1b6c: [e.cash] Add mining section

Summary

Adding the mining section to the bottom of /get-cash

Test Plan

preview the site and navigate to the mining section on /get-ecash
check everything looks good and link works
*note the link will be updated to new blog once thats up, issue created

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

johnkuney created this revision.Jun 21 2023, 21:41

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 21 2023, 21:41

johnkuney requested review of this revision.Jun 21 2023, 21:41

Harbormaster completed remote builds in B24124: Diff 40917.Jun 21 2023, 21:41

@bot preview-e.cash

Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://54.39.104.128:41887 for the next 60 minutes.

bytesofman added inline comments.Jun 21 2023, 22:24

web/e.cash/components/button/styles.js
27 ↗	(On Diff #40917)	looks suspiciously like a patch unrelated to this diff what's goign on with the changes to `/button/styles.js`?

this page:

e.cash:

not related to thsi diff, but seems like the images are much bigger on our current landing page. Since we are already loading large images, should allow them to be as large as possible on the page.

johnkuney added inline comments.Jun 21 2023, 22:34

web/e.cash/components/button/styles.js
27 ↗	(On Diff #40917)	I'll take it out, a button issue was revealed when I added it (the color is not working right on hover)

In D14098#314941, @bytesofman wrote:

this page:

e.cash:

not related to thsi diff, but seems like the images are much bigger on our current landing page. Since we are already loading large images, should allow them to be as large as possible on the page.

For sure

remove button change

Harbormaster completed remote builds in B24126: Diff 40919.Jun 21 2023, 22:44

bytesofman added inline comments.Jun 21 2023, 22:49

web/e.cash/styles/pages/get-ecash.js
17 ↗	(On Diff #40919)	Is this only needed for the Mining `DescriptionBox` added in this diff? Hard for me to see what this does, since it impacts every other DescriptionBox Should also be a separate change

create seperate styled component for the mining section

Harbormaster completed remote builds in B24127: Diff 40920.Jun 22 2023, 01:06

ah sure, those styles were only being applied to the mining section, but bad idea because if another section is added it will not be the last child anymore.
Broke it out to be specific to the mining section

@bot preview-e.cash

Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://54.39.19.73:41857 for the next 60 minutes.

Fabien accepted this revision.Jun 22 2023, 14:26

This revision is now accepted and ready to land.Jun 22 2023, 14:26

Closed by commit rABC063e03dc1b6c: [e.cash] Add mining section (authored by johnkuney). · Explain WhyJun 22 2023, 16:13

This revision was automatically updated to reflect the committed changes.

johnkuney added a commit: rABC063e03dc1b6c: [e.cash] Add mining section.