Page MenuHomePhabricator

[Cashtab] Move the token urls config out of Ticker.js
ClosedPublic

Authored by emack on Jun 23 2023, 14:33.

Details

Summary

Similar to D14102, this diff moves the token specific urls out of Ticker.js and into its own config.

Test Plan
  • grep -r currency.tokenIconSubmitApi src/ and ensure no results
  • grep -r currency.tokenIconsUrl src/ and ensure no results
  • grep -r currency.tokenDbUrl src/ and ensure no results
  • grep -r currency.newTokenDefaultUrl src/ and ensure no results
  • npm test
  • npm start
  • create new token with icon supplied and Document URL left blank, verify new token successfully created, icon displays correctly in app and the default cashtab url is shown in explorer
  • calculate new airdrop and ensure successful onchain parsing
  • send a token

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

emack requested review of this revision.Jun 23 2023, 14:33
Fabien requested changes to this revision.Jun 23 2023, 15:52
Fabien added a subscriber: Fabien.
Fabien added inline comments.
cashtab/src/config/token.js
7 ↗(On Diff #40944)

tokenUrls is redondant here. Either use token, or update the inner keys to not end with Url as well

This revision now requires changes to proceed.Jun 23 2023, 15:52
emack marked an inline comment as done.

updated key reference

This revision is now accepted and ready to land.Jun 24 2023, 07:24