Page MenuHomePhabricator

[Cashtab] Move the websocket config out of Ticker.js
ClosedPublic

Authored by emack on Jun 23 2023, 15:08.

Details

Summary

Similar to D14102, this diff moves the websocket specific urls out of Ticker.js and into its own config.

Test Plan
  • grep -r config.websocketDisconnectedRefreshInterval src/ and ensure no results
  • grep -r config.websocketConnectedRefreshInterval src/ and ensure no results
  • npm test
  • npm start and observe successful wallet refresh intervals
  • send XEC tx and ensure successful broadcast
  • receive XEC tx and ensure successful websocket detection

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

emack requested review of this revision.Jun 23 2023, 15:08
Fabien added a subscriber: Fabien.
Fabien added inline comments.
cashtab/src/config/websocket.js
8 ↗(On Diff #40945)

Nit: move the comment above, and you can just say time is in ms :)

This revision is now accepted and ready to land.Jun 23 2023, 15:53
emack marked an inline comment as done.

updated comments