Paths

Table of Contentst

Differential D14140

[ecash-herald] Remove one-off promise building function from utils and add to its parent function
ClosedPublic
Actions

Authored by bytesofman on Jun 27 2023, 22:05.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCd691cbbc6120: [ecash-herald] Remove one-off promise building function from utils and add to…

Summary

T2972

Depends on D14099

Remove promise building function from utils. Include logic in parent function, only place where it is relevant and used.

Test Plan

npm test

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bytesofman created this revision.Jun 27 2023, 22:05

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 27 2023, 22:05

bytesofman requested review of this revision.Jun 27 2023, 22:05

Harbormaster completed remote builds in B24219: Diff 41050.Jun 27 2023, 22:05

lint

Harbormaster completed remote builds in B24220: Diff 41051.Jun 27 2023, 22:06

remove error comment patch

bytesofman added a child revision: D14141: [ecash-herald] Improve error handling comments in token id info function.Jun 27 2023, 22:08

Harbormaster completed remote builds in B24221: Diff 41052.Jun 27 2023, 22:08

Fabien accepted this revision.Jun 28 2023, 07:18

This revision is now accepted and ready to land.Jun 28 2023, 07:18

Closed by commit rABCd691cbbc6120: [ecash-herald] Remove one-off promise building function from utils and add to… (authored by bytesofman). · Explain WhyJun 28 2023, 17:13

This revision was automatically updated to reflect the committed changes.

bytesofman added a commit: rABCd691cbbc6120: [ecash-herald] Remove one-off promise building function from utils and add to….

Revision Contents
Changeset List

Path

Size

apps/

ecash-herald/

src/

chronik.js

24 lines

utils.js

27 lines

Diff 41079

View Options

apps/ecash-herald/src/chronik.js