Page MenuHomePhabricator
Differential D14162

[ecash-script] Export the getStackArray function
ClosedPublic
Actions

Authored by bytesofman on Jun 29 2023, 23:51.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Commits
rABC214b0d31fd3e: [ecash-script] Export the getStackArray function
Summary

Correctly export getStackArray function from index.js

Test Plan

npm test

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bytesofman created this revision.Jun 29 2023, 23:51
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 29 2023, 23:51
bytesofman requested review of this revision.Jun 29 2023, 23:51
Harbormaster completed remote builds in B24257: Diff 41114.Jun 29 2023, 23:52
PiRK requested changes to this revision.Jun 30 2023, 07:30
PiRK added a subscriber: PiRK.

The test plan does not test the change. It already passes on the current master.

This revision now requires changes to proceed.Jun 30 2023, 07:30
bytesofman updated this revision to Diff 41120.Jun 30 2023, 13:07

Add test confirming exports match

Harbormaster completed remote builds in B24262: Diff 41120.Jun 30 2023, 13:09
PiRK accepted this revision.Jun 30 2023, 13:13
This revision is now accepted and ready to land.Jun 30 2023, 13:13
Closed by commit rABC214b0d31fd3e: [ecash-script] Export the getStackArray function (authored by bytesofman). · Explain WhyJun 30 2023, 16:34
This revision was automatically updated to reflect the committed changes.
bytesofman added a commit: rABC214b0d31fd3e: [ecash-script] Export the getStackArray function.

Revision Contents
Changeset List

PathSize
modules/
ecash-script/
1 line
10 lines
2 lines
test/
25 lines

Diff 41130

View Options

modules/ecash-script/README.md

Loading...
View Options

modules/ecash-script/index.js

Loading...
View Options

modules/ecash-script/package.json

Loading...
View Options

modules/ecash-script/test/index.test.js

Loading...