Page MenuHomePhabricator

[ecashaddrjs] Return type as lowercase for use with chronik
ClosedPublic

Authored by bytesofman on Jun 30 2023, 03:48.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Commits
rABC1b21fb4ab635: [ecashaddrjs] Return type as lowercase for use with chronik
Summary

Originally returned the values as uppercase to be consistent with return of cashaddr.decode without call for true. However, this function is only used to make chronik calls. The all uppercase type always needs to be .toLowerCase()'d in apps where this function is used. So, should fix it here.

Test Plan

npm test

Diff Detail

Repository
rABC Bitcoin ABC
Branch
patch-function-ecashaddrjs
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 24258
Build 48126: Build Diffecashaddrjs-tests
Build 48125: arc lint + arc unit