Page MenuHomePhabricator

[ecash-herald] Remove toLowerCase by using latest ecashaddrjs
ClosedPublic

Authored by bytesofman on Jun 30 2023, 16:32.

Details

Summary

chronik-client only accepts address type in lowercase, i.e. p2sh or p2pkh. Latest version of ecashaddrjs returns these values, so the toLowerCase() shim can be dropped.

Test Plan

npm test

Diff Detail

Repository
rABC Bitcoin ABC
Branch
apply-latest-ecashaddrjs-to-apps
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 24269
Build 48148: Build Diffecash-herald-tests
Build 48147: arc lint + arc unit