Paths

Table of Contentst

Differential D14174

[ecash-herald] Only use others if more than 1 others
ClosedPublic
Actions

Authored by bytesofman on Jun 30 2023, 19:43.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC01d2a5b03d73: [ecash-herald] Only use others if more than 1 others

Summary

T2972

Say "and 1 other" if there is only 1 other recipient, otherwise "and n others"

Test Plan

npm test (this changed mocks of sample blocks, covering this change)

npm run sendMsgByBlock 798881 output is pictured

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bytesofman created this revision.Jun 30 2023, 19:43

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 30 2023, 19:43

bytesofman requested review of this revision.Jun 30 2023, 19:43

Harbormaster completed remote builds in B24273: Diff 41136.Jun 30 2023, 19:45

Fabien accepted this revision.Jul 1 2023, 07:00

This revision is now accepted and ready to land.Jul 1 2023, 07:00

Closed by commit rABC01d2a5b03d73: [ecash-herald] Only use others if more than 1 others (authored by bytesofman). · Explain WhyJul 1 2023, 21:01

This revision was automatically updated to reflect the committed changes.

bytesofman added a commit: rABC01d2a5b03d73: [ecash-herald] Only use others if more than 1 others.

Revision Contents
Changeset List

Path

Size

apps/

ecash-herald/

src/

parse.js

8 lines

test/

mocks/

blocks.js

Diff 41162

View Options

apps/ecash-herald/src/parse.js