Page MenuHomePhabricator
Differential D14184

[Cashtab][Alias] Deprecate alias specific BlockConnected websocket events
ClosedPublic
Actions

Authored by emack on Jul 1 2023, 09:58.

Details

Reviewers
bytesofman
Group Reviewers
Restricted Project
Commits
rABCcf1d050ef655: [Cashtab][Alias] Deprecate alias specific BlockConnected websocket events
Summary

See T3216 for background

Cashtab no longer needs to cache aliases and alias tx histories, therefore there is no need for processChronikWsMsg to be listening on BlockConnected events to refresh local alias cache on new blocks.

There is currently no other uses for 'BlockConnected' events in Cashtab.

Test Plan

npm test
npm start
enable the aliasSettings.aliasEnabled flag in Ticker.js (will be moved in subsequent diff)
open console log and ensure no websocket errors upon new block found as the event should no longer be picked up
disable the aliasFlag, reload cashtab and ensure no websocket errors in console log upon startup

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

emack created this revision.Jul 1 2023, 09:58
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 1 2023, 09:58
emack requested review of this revision.Jul 1 2023, 09:58
Harbormaster completed remote builds in B24293: Diff 41158.Jul 1 2023, 10:01
bytesofman accepted this revision.Jul 1 2023, 21:18

green with comment nit

cashtab/src/hooks/useWallet.js
868–869 ↗(On Diff #41158)
This revision is now accepted and ready to land.Jul 1 2023, 21:18
bytesofman requested changes to this revision.Jul 1 2023, 21:21
bytesofman added inline comments.
cashtab/src/hooks/__tests__/useWallet.test.js
30 ↗(On Diff #41158)

not sure this test proves anything?

looks like null would still be returned with the previous logic

This revision now requires changes to proceed.Jul 1 2023, 21:21
emack updated this revision to Diff 41171.Jul 2 2023, 01:28
emack marked 2 inline comments as done.

Updated chronik websocket tests to specifically differentiate state between AddedToMempool and BlockConnected events

Harbormaster completed remote builds in B24302: Diff 41171.Jul 2 2023, 01:31
bytesofman accepted this revision.Jul 2 2023, 03:21
This revision is now accepted and ready to land.Jul 2 2023, 03:21
Closed by commit rABCcf1d050ef655: [Cashtab][Alias] Deprecate alias specific BlockConnected websocket events (authored by emack). · Explain WhyJul 2 2023, 03:59
This revision was automatically updated to reflect the committed changes.
emack added a commit: rABCcf1d050ef655: [Cashtab][Alias] Deprecate alias specific BlockConnected websocket events.
emack mentioned this in D14199: [Cashtab][Alias] Deprecate getLatestAliases.Jul 3 2023, 14:59
emack mentioned this in rABC7bc02bf55caa: [Cashtab][Alias] Deprecate getLatestAliases.Jul 3 2023, 15:28

Revision Contents
Changeset List

PathSize
cashtab/
src/
hooks/
__tests__/
28 lines
27 lines

Diff 41177

View Options

cashtab/src/hooks/__tests__/useWallet.test.js

Loading...
View Options

cashtab/src/hooks/useWallet.js

Loading...