[Cashtab][Alias] Deprecate getLatestAliases
ClosedPublic
Actions

Authored by emack on Jul 3 2023, 14:59.

Details

Reviewers

bytesofman

Group Reviewers

Restricted Project

Commits

rABC7bc02bf55caa: [Cashtab][Alias] Deprecate getLatestAliases

Summary

T3216

Alias caching is now being incrementally deprecated in cashtab and alias data will be retrieved directly via api endpoints. Therefore removing the getLatestAliases function.

This function's alias related interdependencies have all been deprecated prior to this diff via D14186 and D14184.

Test Plan

npm test
grep -r getLatestAliases src/ and ensure no outputs
npm start
send a transaction, switch wallets, ensure no unexpected issues whilst alias flag in Ticker.js continues to be false

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

emack created this revision.Jul 3 2023, 14:59

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 3 2023, 14:59

emack requested review of this revision.Jul 3 2023, 14:59

emack edited the summary of this revision. (Show Details)Jul 3 2023, 14:59

Harbormaster completed remote builds in B24327: Diff 41221.Jul 3 2023, 15:09

bytesofman accepted this revision.Jul 3 2023, 15:19

bytesofman added inline comments.

cashtab/src/hooks/useWallet.js
63 ↗	(On Diff #41221)	OK to remove here. Note that when we implement the existing server endpoints, we will still want to disable alias registrations if we don't get a good API response from the server about the availability of a given alias

This revision is now accepted and ready to land.Jul 3 2023, 15:19

emack marked an inline comment as done.Jul 3 2023, 15:28

emack added inline comments.

cashtab/src/hooks/useWallet.js
63 ↗	(On Diff #41221)	yup noted. It had to be removed otherwise it will fail linting rules on account of getLatestAliases being the only function left that used it