[Cashtab][Alias] Deprecate isAliasServerOnline
ClosedPublic
Actions

Authored by emack on Jul 11 2023, 06:50.

Details

Reviewers

bytesofman

Group Reviewers

Restricted Project

Commits

rABCb9969d7c99e2: [Cashtab][Alias] Deprecate isAliasServerOnline

Summary

T3216

As per feedback from D14211, removing the redundant isAliasServerOnline as the newly implemented alias-server wrappers already cater for the non-responsive server and other error scenarios.

Test Plan

grep -r isAliasServerOnline src/ and ensure no outputs
npm test

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

emack created this revision.Jul 11 2023, 06:50

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 11 2023, 06:50

emack requested review of this revision.Jul 11 2023, 06:50

Harbormaster completed remote builds in B24441: Diff 41369.Jul 11 2023, 06:53

emack mentioned this in D14211: [Cashtab][Alias] Refactor Alias.js to use new alias-server endpoints.Jul 11 2023, 06:53

Fabien added a subscriber: Fabien.Jul 11 2023, 07:24

Fabien added inline comments.

cashtab/src/components/Alias/Alias.js
157 ↗	(On Diff #41369)	where is this flag set/unset ?

emack marked an inline comment as done.Jul 11 2023, 07:53

emack added inline comments.

cashtab/src/components/Alias/Alias.js
157 ↗	(On Diff #41369)	this was previously set in useWallet.js, defaulting to true, and whereby upon app startup it hits `getLatestAliases()` and commits it to local storage. If that initialization was successful then `isAliasServerOnline` would flow through as true via the WalletContext. In the preceding diff D14199, `getLatestAliases` was deprecated, which necessitated the removal of the `isAliasServerOnline` state variable on the useWallet.js side otherwise it would break linting rules since it was only used by `getLatestAliases`.