[ecash-herald] Patch sync functions defined as async in utils unit test
ClosedPublic
Actions

Authored by bytesofman on Jul 1 2023, 22:24.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABC0cd8a89cc7d0: [ecash-herald] Patch sync functions defined as async in utils unit test

Summary

Depends on D14187

A lot of sync unit tests are defined as async since an API testing function was copy pasted as a template a long time ago. Patch it.

Test Plan

npm test

Diff Detail

Repository

rABC Bitcoin ABC

Branch

tighten-xecsend-lines

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 24299
Build 48208: Build Diff	ecash-herald-tests
Build 48207: arc lint + arc unit

Event Timeline

bytesofman created this revision.Jul 1 2023, 22:24

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 1 2023, 22:24

bytesofman requested review of this revision.Jul 1 2023, 22:24

Harbormaster completed remote builds in B24299: Diff 41167.Jul 1 2023, 22:25

PiRK accepted this revision.Jul 2 2023, 19:13

This revision is now accepted and ready to land.Jul 2 2023, 19:13

Closed by commit rABC0cd8a89cc7d0: [ecash-herald] Patch sync functions defined as async in utils unit test (authored by bytesofman). · Explain WhyJul 2 2023, 22:09

This revision was automatically updated to reflect the committed changes.

bytesofman added a commit: rABC0cd8a89cc7d0: [ecash-herald] Patch sync functions defined as async in utils unit test.

Revision Contents
Changeset List

Path

Size

apps/

ecash-herald/

test/

utilsTests.js

70 lines

Diff 41167

View Options

apps/ecash-herald/test/utilsTests.js

[ecash-herald] Patch sync functions defined as async in utils unit testClosedPublicActions