[Cashtab] Improve isValidStoredWallet validation
ClosedPublic
Actions

Authored by emack on Jul 2 2023, 01:53.

Details

Reviewers

bytesofman

Group Reviewers

Restricted Project

Commits

rABC890a4217c28f: [Cashtab] Improve isValidStoredWallet validation

Summary

As per feedback from D14186, updating isValidStoredWallet validation logic to also check for name, mnemonic, Path245, Path145 and Path1899 keys in the wallet object.

Test Plan

npm test

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

emack created this revision.Jul 2 2023, 01:53

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 2 2023, 01:53

emack requested review of this revision.Jul 2 2023, 01:53

Harbormaster completed remote builds in B24303: Diff 41172.Jul 2 2023, 01:56

emack mentioned this in D14186: [Cashtab][Alias] Deprecate alias history refresh in handleUpdateWallet.Jul 2 2023, 01:57

bytesofman requested changes to this revision.Jul 2 2023, 03:24

bytesofman added inline comments.

cashtab/src/utils/cashMethods.js
1075 ↗	(On Diff #41172)	Add a unit test that shows `isValidStoredWallet` is false for a wallet missing one of these newly added checked fields, i.e. `name` or `mnemonic` or both

This revision now requires changes to proceed.Jul 2 2023, 03:24

Updated unit tests

Harbormaster completed remote builds in B24307: Diff 41181.Jul 2 2023, 05:24

Build Bitcoin ABC Diffs / Diff Testing (cashtab-tests) failed.

Failed tests logs:

====== CashTab Unit Tests:  Verify processChronikWsMsg() processes AddedToMempool events ======
assert.notEqual(received, expected)

Expected value to not be equal to:
  null
Received:
  null

Difference:

Compared values have no visual difference.
    at Object.<anonymous> (/work/cashtab/src/hooks/__tests__/useWallet.test.js:42:12)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)

Each failure log is accessible here:
CashTab Unit Tests: Verify processChronikWsMsg() processes AddedToMempool events

@bot cashtab-tests

teamcity awarded a token.Jul 2 2023, 12:58

In D14190#317011, @teamcity wrote:
Build Bitcoin ABC Diffs / Diff Testing (cashtab-tests) failed.

Failed tests logs:
====== CashTab Unit Tests:  Verify processChronikWsMsg() processes AddedToMempool events ======
assert.notEqual(received, expected)

Expected value to not be equal to:
  null
Received:
  null

Difference:

Compared values have no visual difference.
    at Object.<anonymous> (/work/cashtab/src/hooks/__tests__/useWallet.test.js:42:12)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
Each failure log is accessible here:
CashTab Unit Tests: Verify processChronikWsMsg() processes AddedToMempool events

mb a rebase issue?

This revision now requires changes to proceed.Jul 2 2023, 12:58

mb a rebase issue?

Will re-run once D14192 finishes building

@bot cashtab-tests

teamcity updated a token.Jul 2 2023, 13:30

Build Bitcoin ABC Diffs / Diff Testing (cashtab-tests) failed.

Failed tests logs:

====== CashTab Unit Tests:  Verify processChronikWsMsg() processes AddedToMempool events ======
assert.notEqual(received, expected)

Expected value to not be equal to:
  null
Received:
  null

Difference:

Compared values have no visual difference.
    at Object.<anonymous> (/work/cashtab/src/hooks/__tests__/useWallet.test.js:42:12)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)

Each failure log is accessible here:
CashTab Unit Tests: Verify processChronikWsMsg() processes AddedToMempool events