Page MenuHomePhabricator

[ecash-herald] Limit number of displayed xec send txs
ClosedPublic

Authored by bytesofman on Jul 3 2023, 23:26.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Commits
rABC1065c6900aa2: [ecash-herald] Limit number of displayed xec send txs
Summary

Some large blocks create very long msgs, which take multiple telegram msgs. A general principle is that we want each message to be as short and as interesting as possible.

Do not show too many eCash send msgs in the block. This diff simply displays the 12 biggest xec send txs. Better filtering can be introduced going fwd (for example, mb we want only whale wallet sends, or only known addresses, etc...some formula to get the most interesting txs).

Test Plan

npm run sendMsgByBlock 799298 output is pictured.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
limit-displayed-xec-txs
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 24333
Build 48275: Build Diffecash-herald-tests
Build 48274: arc lint + arc unit