Page MenuHomePhabricator

[e.cash] Homepage buttons
ClosedPublic

Authored by johnkuney on Jul 5 2023, 17:19.

Details

Reviewers
bytesofman
Group Reviewers
Restricted Project
Commits
rABCf4e10743cef0: [e.cash] Homepage buttons
Summary

Adding the other buttons to the homepage hero section

Test Plan

preview the site and check the button look right and work

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

hm e.cash build seem to be down due to 502 error trying to make http request

image.png (242×481 px, 24 KB)

If no url's have changed most likely some kind of server issue

web/e.cash/styles/pages/homepage.js
90 ↗(On Diff #41270)

prob ok since we won't ever change the amount of buttons

is this the same as last-child? could we use that?

bytesofman requested changes to this revision.Jul 7 2023, 15:51

image.png (786×1 px, 378 KB)

issue with size of central page at some widths, 960px pictured

This revision now requires changes to proceed.Jul 7 2023, 15:51

ah yeah I just noticed that last night, actually coming from the the footer, the new pages made the amount links wider causing some to run off the page at medium screen sizes. Need to adjust. Made an issue, assume out of scope here

This revision is now accepted and ready to land.Jul 7 2023, 16:33
This revision was automatically updated to reflect the committed changes.