Paths

Table of Contentst

Differential D14220

[electrum] fix storage.requires_upgrade and test it
ClosedPublic
Actions

Authored by PiRK on Jul 6 2023, 14:37.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABCdb032ca6cbf6: [electrum] fix storage.requires_upgrade and test it

Summary

WalletStorage.requires_upgrade always returned None, which is False. This is clearly a bug introduced when splitting the WalletStorage and JsonDB classes.

Fix it and test it.

This is currently used in the code to guard against loading (and potentially corrupting) old wallets that are not updated to the current format. But this should not happen except in the tests (when manual_upgrades=True is passed to the constructor), as the upgrade is done automatically when initializing a JsonDB class.

Test Plan

ninja check-electrum

This fails with this test fix and without the code fix.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

fix_requires_upgrade

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 24382
Build 48373: Build Diff	electrum-tests
Build 48372: arc lint + arc unit

Event Timeline

PiRK created this revision.Jul 6 2023, 14:37

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 6 2023, 14:37

PiRK requested review of this revision.Jul 6 2023, 14:37

Harbormaster completed remote builds in B24381: Diff 41288.Jul 6 2023, 14:39

also add typehints so that mypy and pycharm can warn about the issue the next time it happens

Harbormaster completed remote builds in B24382: Diff 41289.Jul 6 2023, 14:49

bytesofman accepted this revision.Jul 6 2023, 15:58

This revision is now accepted and ready to land.Jul 6 2023, 15:58

python test_runner.py checks out

Closed by commit rABCdb032ca6cbf6: [electrum] fix storage.requires_upgrade and test it (authored by PiRK). · Explain WhyJul 7 2023, 07:13

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABCdb032ca6cbf6: [electrum] fix storage.requires_upgrade and test it.

Revision Contents
Changeset List

Path

Size

electrum/

electrumabc/

4 lines

6 lines

tests/

test_storage_upgrade.py

1 line

Diff 41289

electrum/electrumabc/json_db.py

Loading...

electrum/electrumabc/storage.py

Loading...

electrum/electrumabc/tests/test_storage_upgrade.py

Loading...

electrum/test_runner.py

Loading...