T3200
Show xec send info for Cashtab msg txs
Details
Details
- Reviewers
Fabien - Group Reviewers
Restricted Project - Commits
- rABC66b0b750f8a6: [ecash-herald] Show sent amount for Cashtab msgs
npm test, image output for Cashtab msg shown
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
The problem here is that it's impossible to tell if the change is tested properly.
| apps/ecash-herald/test/mocks/blocks.js | ||
|---|---|---|
| 84 ↗ | (On Diff #41307) | These changes are unrelated to the diff |
Comment Actions
true. This is a broader problem than this diff. Will get a diff together that generatesMocks on constant API data. This will also stop unrelated changes like price updates, utxo set swaps, etc.
| apps/ecash-herald/src/parse.js | ||
|---|---|---|
| 1204 ↗ | (On Diff #41356) | Unless I'm missing something this is converting to dollars, not XEC ? |
Comment Actions
This was about the comment, which tells the code converts sats to XEC with rounding while it is converting sats to dollars