Differential D14229

[electrum] remove unused objects and methods in wallet
ClosedPublic
Actions

Authored by PiRK on Jul 7 2023, 14:49.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCbc5afdc3b98b: [electrum] remove unused objects and methods in wallet

Summary

Nothing in this codebase needs the old versions of the code, except for one callsite in main_window which is easy to update to use the new version.
Remove the technical debt.

Test Plan

python electrum/test_runner.py

Test run the application

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Jul 7 2023, 14:49

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 7 2023, 14:49

PiRK requested review of this revision.Jul 7 2023, 14:49

Harbormaster completed remote builds in B24404: Diff 41316.Jul 7 2023, 14:51

PiRK planned changes to this revision.Jul 7 2023, 14:56

PiRK added inline comments.

electrum/electrumabc/wallet.py
826 ↗	(On Diff #41316)	something went wrong here

put status_enum as the last field in the TxInfo namedtuple definition

Harbormaster completed remote builds in B24405: Diff 41317.Jul 7 2023, 15:00

Fabien accepted this revision.Jul 7 2023, 16:12

Fabien added a subscriber: Fabien.

Fabien added inline comments.

electrum/electrumabc/wallet.py
763 ↗	(On Diff #41317)

This revision is now accepted and ready to land.Jul 7 2023, 16:12

fix typename for namedtuple

Harbormaster completed remote builds in B24409: Diff 41323.Jul 7 2023, 18:15

Closed by commit rABCbc5afdc3b98b: [electrum] remove unused objects and methods in wallet (authored by PiRK). · Explain WhyJul 8 2023, 06:26

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABCbc5afdc3b98b: [electrum] remove unused objects and methods in wallet.

Revision Contents
Changeset List

Path

Size

electrum/

electrumabc/

wallet.py

57 lines

electrumabc_gui/

qt/

main_window.py

8 lines

Diff 41327

View Options

electrum/electrumabc/wallet.py