[electrum] make functional tests works for python < 3.10
ClosedPublic
Actions

Authored by PiRK on Jul 17 2023, 10:57.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC7d51a4df89a3: [electrum] make functional tests works for python < 3.10

Summary

PEP 604 union types were added in Python 3.10, and we still support 3.7.

See https://peps.python.org/pep-0604/

Test Plan

With pyenv installed and pyenv install 3.7.0:

~/.pyenv/versions/3.7.0/bin/python -m pytest electrum/electrumabc/tests/regtest/

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Jul 17 2023, 10:57

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 17 2023, 10:57

PiRK requested review of this revision.Jul 17 2023, 10:57

Harbormaster completed remote builds in B24511: Diff 41467.Jul 17 2023, 10:59

PiRK added a child revision: D14275: [electrum] add a build configuration for functional tests.Jul 17 2023, 10:59

Fabien accepted this revision.Jul 17 2023, 12:34

This revision is now accepted and ready to land.Jul 17 2023, 12:34

Closed by commit rABC7d51a4df89a3: [electrum] make functional tests works for python < 3.10 (authored by PiRK). · Explain WhyJul 17 2023, 14:38

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC7d51a4df89a3: [electrum] make functional tests works for python < 3.10.

Revision Contents
Changeset List

Path

Size

electrum/

electrumabc/

tests/

regtest/

util.py

6 lines

Diff 41471

View Options

electrum/electrumabc/tests/regtest/util.py

[electrum] make functional tests works for python < 3.10ClosedPublicActions