Page MenuHomePhabricator
Differential D14291

[electrum] use the docker-compose command for functional tests
ClosedPublic
Actions

Authored by PiRK on Jul 19 2023, 19:06.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC774d5ea48262: [electrum] use the docker-compose command for functional tests
Summary

As of pytest-docker 2.0.0, docker-compose is no longer the default command. The default docker compose command now requires a newer version of docker than what is packaged for debian, so add a docker_compose_command pytest fixture to switch back to the previous behavior.

Test Plan

@bot electrum-functional-tests

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Jul 19 2023, 19:06
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 19 2023, 19:06
PiRK requested review of this revision.Jul 19 2023, 19:06
PiRK added a comment.Jul 19 2023, 19:07

@bot electrum-functional-tests

teamcity awarded a token.Jul 19 2023, 19:07
Harbormaster completed remote builds in B24555: Diff 41529.Jul 19 2023, 19:07
PiRK added a comment.Jul 19 2023, 19:14

@bot electrum-functional-tests

PiRK added a comment.Jul 19 2023, 19:14

@bot electrum-functional-tests

teamcity updated a token.Jul 19 2023, 19:14
PiRK updated this revision to Diff 41530.Jul 19 2023, 19:14

remove the debugging print that did not work anyway. We can see in the build log whick version of pytest-docker it is using (depends on whether the build agent installed it today or yesterday):

  • new version: plugins: teamcity-messages-1.28, docker-2.0.0
  • previous version: plugins: docker-1.0.1, teamcity-messages-1.28
teamcity updated a token.Jul 19 2023, 19:14
Harbormaster completed remote builds in B24556: Diff 41530.Jul 19 2023, 19:16
PiRK added a comment.Jul 19 2023, 19:16

@bot electrum-functional-tests

PiRK added a comment.Jul 19 2023, 19:16

@bot electrum-functional-tests

teamcity updated a token.Jul 19 2023, 19:16
teamcity updated a token.
PiRK added a comment.Jul 19 2023, 19:16

@bot electrum-functional-tests

teamcity updated a token.Jul 19 2023, 19:16
PiRK added a comment.Jul 19 2023, 19:16

@bot electrum-functional-tests

teamcity updated a token.Jul 19 2023, 19:16
PiRK added a comment.Jul 19 2023, 19:16

@bot electrum-functional-tests

PiRK added a comment.Jul 19 2023, 19:17

@bot electrum-functional-tests

teamcity updated a token.Jul 19 2023, 19:17
teamcity updated a token.
PiRK added a comment.Jul 19 2023, 19:19

This one succeeded with the new version of pytest-docker: https://build.bitcoinabc.org/viewLog.html?buildId=593490&buildTypeId=BitcoinABC_BitcoinAbcStaging&tab=buildLog

PiRK retitled this revision from [electrum] use the docker-compose for functional tests to [electrum] use the docker-compose command for functional tests.Jul 19 2023, 19:20
Fabien accepted this revision.Jul 20 2023, 08:19
This revision is now accepted and ready to land.Jul 20 2023, 08:19
Closed by commit rABC774d5ea48262: [electrum] use the docker-compose command for functional tests (authored by PiRK). · Explain WhyJul 20 2023, 09:32
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC774d5ea48262: [electrum] use the docker-compose command for functional tests.

Revision Contents
Changeset List

PathSize
electrum/
electrumabc/
tests/
regtest/
7 lines
7 lines
10 lines

Diff 41536

View Options

electrum/electrumabc/tests/regtest/test_rpc_misc.py

Loading...
View Options

electrum/electrumabc/tests/regtest/test_rpc_payment_request.py

Loading...
View Options

electrum/electrumabc/tests/regtest/util.py

Loading...