Page MenuHomePhabricator
Differential D14313

fix chronik bridgeprimitives_tests
ClosedPublic
Actions

Authored by PiRK on Jul 27 2023, 06:44.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCd98da933b2fd: fix chronik bridgeprimitives_tests
Summary

D14312 broke this test

The coinbase transaction size went down from 108 bytes to 106 bytes for 200 blocks.

Test Plan
cmake .. -GNinja -DBUILD_BITCOIN_CHRONIK=ON
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Branch
test_fix_mining
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 24603
Build 48803: Build Diffbuild-chronik
Build 48802: arc lint + arc unit

Event Timeline

PiRK created this revision.Jul 27 2023, 06:44
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 27 2023, 06:44
PiRK added a comment.Jul 27 2023, 06:44

@bot build-linux64

teamcity awarded a token.Jul 27 2023, 06:44
PiRK updated this revision to Diff 41604.Jul 27 2023, 06:50

fix dterministic hashes in rpc_dumptxoutset

Harbormaster completed remote builds in B24601: Diff 41603.Jul 27 2023, 06:52
teamcity added a comment.Jul 27 2023, 06:52
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
teamcity added a comment.Jul 27 2023, 06:56
Build Bitcoin ABC Diffs / Diff Testing (build-debug) failed.

Failed tests logs:

====== Bitcoin ABC functional tests: rpc_dumptxoutset.py ======

------- Stdout: -------
2023-07-27T06:54:47.780000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20230727_064847/rpc_dumptxoutset_206
2023-07-27T06:54:48.488000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 142, in main
    self.run_test()
  File "/work/test/functional/rpc_dumptxoutset.py", line 36, in run_test
    assert_equal(
  File "/work/test/functional/test_framework/util.py", line 62, in assert_equal
    raise AssertionError(
AssertionError: not(2bffc8d97891504aeca1a0bb8c28baffbd50fb54c03be52c594a2fd3c7c87975 == 53bd41279adf93df5bb1f51c84d3409aeba14d4276238ae30f813ff27e711ad7)
2023-07-27T06:54:48.539000Z TestFramework (INFO): Stopping nodes
2023-07-27T06:54:48.640000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20230727_064847/rpc_dumptxoutset_206
2023-07-27T06:54:48.640000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20230727_064847/rpc_dumptxoutset_206/test_framework.log
2023-07-27T06:54:48.640000Z TestFramework (ERROR): 
2023-07-27T06:54:48.640000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20230727_064847/rpc_dumptxoutset_206' to consolidate all logs
2023-07-27T06:54:48.640000Z TestFramework (ERROR): 
2023-07-27T06:54:48.640000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2023-07-27T06:54:48.640000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2023-07-27T06:54:48.640000Z TestFramework (ERROR):

Each failure log is accessible here:
Bitcoin ABC functional tests: rpc_dumptxoutset.py

teamcity added a comment.Jul 27 2023, 06:59
Build Bitcoin ABC Diffs / Diff Testing (build-diff) failed.

Failed tests logs:

====== Bitcoin ABC functional tests: rpc_dumptxoutset.py ======

------- Stdout: -------
2023-07-27T06:54:54.414000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20230727_065052/rpc_dumptxoutset_206
2023-07-27T06:54:54.745000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 142, in main
    self.run_test()
  File "/work/test/functional/rpc_dumptxoutset.py", line 36, in run_test
    assert_equal(
  File "/work/test/functional/test_framework/util.py", line 62, in assert_equal
    raise AssertionError(
AssertionError: not(2bffc8d97891504aeca1a0bb8c28baffbd50fb54c03be52c594a2fd3c7c87975 == 53bd41279adf93df5bb1f51c84d3409aeba14d4276238ae30f813ff27e711ad7)
2023-07-27T06:54:54.796000Z TestFramework (INFO): Stopping nodes
2023-07-27T06:54:54.897000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20230727_065052/rpc_dumptxoutset_206
2023-07-27T06:54:54.897000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20230727_065052/rpc_dumptxoutset_206/test_framework.log
2023-07-27T06:54:54.897000Z TestFramework (ERROR): 
2023-07-27T06:54:54.897000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20230727_065052/rpc_dumptxoutset_206' to consolidate all logs
2023-07-27T06:54:54.897000Z TestFramework (ERROR): 
2023-07-27T06:54:54.897000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2023-07-27T06:54:54.898000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2023-07-27T06:54:54.898000Z TestFramework (ERROR):
====== Bitcoin ABC functional tests with the next upgrade activated: rpc_dumptxoutset.py ======

------- Stdout: -------
2023-07-27T06:58:50.673000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20230727_065501/rpc_dumptxoutset_206
2023-07-27T06:58:50.997000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 142, in main
    self.run_test()
  File "/work/test/functional/rpc_dumptxoutset.py", line 36, in run_test
    assert_equal(
  File "/work/test/functional/test_framework/util.py", line 62, in assert_equal
    raise AssertionError(
AssertionError: not(2bffc8d97891504aeca1a0bb8c28baffbd50fb54c03be52c594a2fd3c7c87975 == 53bd41279adf93df5bb1f51c84d3409aeba14d4276238ae30f813ff27e711ad7)
2023-07-27T06:58:51.048000Z TestFramework (INFO): Stopping nodes
2023-07-27T06:58:51.149000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20230727_065501/rpc_dumptxoutset_206
2023-07-27T06:58:51.149000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20230727_065501/rpc_dumptxoutset_206/test_framework.log
2023-07-27T06:58:51.149000Z TestFramework (ERROR): 
2023-07-27T06:58:51.149000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20230727_065501/rpc_dumptxoutset_206' to consolidate all logs
2023-07-27T06:58:51.149000Z TestFramework (ERROR): 
2023-07-27T06:58:51.149000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2023-07-27T06:58:51.149000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2023-07-27T06:58:51.150000Z TestFramework (ERROR):

Each failure log is accessible here:
Bitcoin ABC functional tests: rpc_dumptxoutset.py
Bitcoin ABC functional tests with the next upgrade activated: rpc_dumptxoutset.py

teamcity added a comment.Jul 27 2023, 07:03
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
PiRK updated this revision to Diff 41605.Jul 27 2023, 07:12
PiRK retitled this revision from test a fix to fix chronik bridgeprimitives_tests.
PiRK edited the summary of this revision. (Show Details)
PiRK edited the test plan for this revision. (Show Details)

update the data_pos in the failing test

Harbormaster completed remote builds in B24602: Diff 41604.Jul 27 2023, 07:14
PiRK added a comment.Jul 27 2023, 07:14

@bot build-linux64

teamcity updated a token.Jul 27 2023, 07:14
Harbormaster completed remote builds in B24603: Diff 41605.Jul 27 2023, 07:29
PiRK published this revision for review.Jul 27 2023, 08:27
PiRK edited the summary of this revision. (Show Details)
Fabien accepted this revision.Jul 27 2023, 08:59
This revision is now accepted and ready to land.Jul 27 2023, 08:59
Closed by commit rABCd98da933b2fd: fix chronik bridgeprimitives_tests (authored by PiRK). · Explain WhyJul 27 2023, 09:18
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABCd98da933b2fd: fix chronik bridgeprimitives_tests.

Revision Contents
Changeset List

PathSize
chronik/
test/
8 lines

Diff 41605

View Options

chronik/test/bridgeprimitives_tests.cpp

Loading...