[alias-server] Only add aliases to db if blockheight is avalanche confirmed
ClosedPublic
Actions

Authored by bytesofman on Jul 28 2023, 18:22.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC3b0d8378306a: [alias-server] Only add aliases to db if blockheight is avalanche confirmed

Summary

This is (almost) handled by only trying to update the server state if we have a blockheight that is avalanche confirmed. However, the chronik call to get tx history occurs after we have this avalanche confirmed block.

Possible edge case where

Block comes in as avalanche confirmed
Another block confirms before chronik call to get tx history
Tx history is returned with some txs having a blockheight higher than the avalanche confirmed height of the server

In this case, we do not want to add any of these txs as valid alias registrations. They may indeed be valid, but they need to be picked up in the next loop processing an avalanche confirmed block.

Test Plan

npm test

Diff Detail

Repository

rABC Bitcoin ABC

Branch

alias-server-confirm-avalanche

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 24618
Build 48833: Build Diff	alias-server-tests
Build 48832: arc lint + arc unit

Event Timeline

bytesofman created this revision.Jul 28 2023, 18:22

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 28 2023, 18:22

bytesofman requested review of this revision.Jul 28 2023, 18:22

Harbormaster completed remote builds in B24617: Diff 41626.Jul 28 2023, 18:24

bytesofman added inline comments.Jul 28 2023, 18:24

apps/alias-server/test/chronikWsHandlerTests.js
145 ↗	(On Diff #41626)	Annoyingly but reassuringly -- these unit tests where I had just picked a random blockheight as it was not critical to the unit test all broke with this change, as this blockheight will cut off some of the valid registrations in the app mocks with this change implemented.