Differential D1433

Use TxId when constructing a CTxIn
ClosedPublic
Actions

Authored by deadalnix on May 22 2018, 12:32.

Details

Reviewers

jasonbcox

Group Reviewers

Restricted Project

Commits

rSTAGINGb7f75a2befec: Use TxId when constructing a CTxIn
rABCb7f75a2befec: Use TxId when constructing a CTxIn

Summary

Increase type safety.

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

deadalnix created this revision.May 22 2018, 12:32

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 22 2018, 12:32

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B2605: Diff 3926.May 22 2018, 13:08

jasonbcox accepted this revision.May 23 2018, 05:00

This revision is now accepted and ready to land.May 23 2018, 05:00

Closed by commit rABCb7f75a2befec: Use TxId when constructing a CTxIn (authored by deadalnix). · Explain WhyMay 23 2018, 08:05

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

bitcoin-tx.cpp

2 lines

primitives/

transaction.h

4 lines

validation.cpp

2 lines

Diff 3943

View Options

src/bitcoin-tx.cpp

View Options

src/primitives/transaction.h

View Options

Use TxId when constructing a CTxInClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 3943

src/bitcoin-tx.cpp

src/primitives/transaction.h

src/validation.cpp

Use TxId when constructing a CTxIn
ClosedPublic
Actions

Revision Contents
Changeset List