Page MenuHomePhabricator
Differential D14338

[doc] Add suggestion to use Phorge Arcanist to CONTRIBUTING file
ClosedPublic
Actions

Authored by Mengerian on Aug 2 2023, 23:40.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCb84642e0c215: [doc] Add suggestion to use Phorge Arcanist to CONTRIBUTING file
Summary

Phorge version of Arcanist is actually maintained and works properly.

Test Plan

I followed these instructions on Ubuntu 22.04 and things are working well.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Mengerian created this revision.Aug 2 2023, 23:40
Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 2 2023, 23:40
Mengerian requested review of this revision.Aug 2 2023, 23:40
Harbormaster completed remote builds in B24663: Diff 41687.Aug 2 2023, 23:40
Mengerian updated this revision to Diff 41688.Aug 2 2023, 23:48

Fix typo

Harbormaster completed remote builds in B24664: Diff 41688.Aug 2 2023, 23:48
Fabien requested changes to this revision.Aug 3 2023, 08:45
Fabien added inline comments.
CONTRIBUTING.md
99–100 ↗(On Diff #41688)
This revision now requires changes to proceed.Aug 3 2023, 08:45
Mengerian updated this revision to Diff 41700.Aug 3 2023, 15:48

Simplify sentence as per review feedback

Harbormaster completed remote builds in B24673: Diff 41700.Aug 3 2023, 15:49
Mengerian updated this revision to Diff 41701.Aug 3 2023, 16:04

Specify "Phabricator version of Arcanist", to remain consistent with "Phorge version of Arcanist".
After all, they are both "Arcanist".

Harbormaster completed remote builds in B24674: Diff 41701.Aug 3 2023, 16:04
Fabien accepted this revision.Aug 3 2023, 16:12
This revision is now accepted and ready to land.Aug 3 2023, 16:12
Mengerian updated this revision to Diff 41702.Aug 3 2023, 16:12

Phorge Arcanist fork -> Phorge version of Arcanist

Harbormaster completed remote builds in B24675: Diff 41702.Aug 3 2023, 16:12
Closed by commit rABCb84642e0c215: [doc] Add suggestion to use Phorge Arcanist to CONTRIBUTING file (authored by Mengerian). · Explain WhyAug 3 2023, 16:15
This revision was automatically updated to reflect the committed changes.
Mengerian added a commit: rABCb84642e0c215: [doc] Add suggestion to use Phorge Arcanist to CONTRIBUTING file.

Revision Contents
Changeset List

PathSize
4 lines

Diff 41703

View Options

CONTRIBUTING.md

Loading...