removing the GA id and weglot key from this public repo to instead be inserted in the CI build
Details
Details
- Reviewers
bytesofman Fabien - Group Reviewers
Restricted Project - Commits
- rABC6515aa92fb65: [e.cash] Remove env vars from repo
preview the site and everything should function as before but GA and weglot will have undefined for their id values
You should see some text in the top right explaining this if they are absent
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- ecash-weglot-project-switch
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 24749 Build 49090: Build Diff Build 49089: arc lint + arc unit
Event Timeline
Comment Actions
Let's move these ids out of the repo instead:
- let the code work with no env var set
- remove the env variables (same for google analytics) from the repo
- generate a new api key for google and for the "original" translation project
- update the CI to call the deployment/preview with the appropriated key as env vars
Comment Actions
Okay removed them here. Page will still work like this, just weglot and GA wont as the ids are undefined.
I'm not sure how you update the CI to call the deployment/preview with the appropriate key as env vars though. Were you going to do that part?
Comment Actions
@Fabien I've updated these in the "Build eCash" step in teamcity -- let me know if implementation is correct
Comment Actions
Okay removed them here. Page will still work like this, just weglot and GA wont as the ids are undefined.
Can we have a discrete banner that explains that the feature is disabled because the appropriated env var is unset ?
I'm not sure how you update the CI to call the deployment/preview with the appropriate key as env vars though. Were you going to do that part?
Either @bytesofman or myself can do that
Comment Actions
Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://54.39.104.128:41661 for the next 60 minutes.