Page MenuHomePhabricator

[e.cash] Rename "ecash-brand" page to "brand"
ClosedPublic

Authored by Mengerian on Aug 11 2023, 14:37.

Details

Reviewers
johnkuney
Fabien
Group Reviewers
Restricted Project
Commits
rABCa5b3d3325dfe: [e.cash] Rename "ecash-brand" page to "brand"
Summary

e.cash/brand is a better url, e.cash/ecash-brand is redundant.

Also redirect e.cash/ecash-brand in case there are external links out in the wild.

Test Plan

npm run dev
Check that navigation links go to localhost:3000/brand
Type in localhost:3000/ecash-brand and check that it redirects to localhost:3000/brand`

Diff Detail

Repository
rABC Bitcoin ABC
Branch
brand
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 24734
Build 49060: Build Diff
Build 49059: arc lint + arc unit

Event Timeline

Tail of the build log:

#7 9.682 npm notice Run `npm install -g npm@9.8.1` to update!
#7 9.682 npm notice 
#7 DONE 11.9s

#8 [4/4] RUN npm run build
#8 sha256:116443e5e2dd707fb11257f1ed155814f70c45f413e4cddf51d043039ab134dc
#8 0.788 
#8 0.788 > e.cash@0.0.1 build
#8 0.788 > next build
#8 0.788 
#8 0.999 info  - Loaded env from /.env.local
#8 1.122 Attention: Next.js now collects completely anonymous telemetry regarding usage.
#8 1.122 This information is used to shape Next.js' roadmap and prioritize features.
#8 1.122 You can learn more, including how to opt-out if you'd not like to participate in this anonymous program, by visiting the following URL:
#8 1.122 https://nextjs.org/telemetry
#8 1.122 
#8 1.208 info  - Linting and checking validity of types...
#8 3.452 info  - Creating an optimized production build...
#8 3.694 Browserslist: caniuse-lite is outdated. Please run:
#8 3.694   npx browserslist@latest --update-db
#8 3.694   Why you should do it regularly: https://github.com/browserslist/browserslist#browsers-data-updating
#8 10.62 info  - Compiled successfully
#8 10.62 info  - Collecting page data...
#8 12.87 info  - Generating static pages (0/97)
#8 13.70 
#8 13.70 Error occurred prerendering page "/get-ecash". Read more: https://nextjs.org/docs/messages/prerender-error
#8 13.70 Error: FetchError: invalid json response body at https://api.scorecard.cash/instant-exchanges reason: Unexpected token < in JSON at position 0
#8 13.70     at getScoreCardData (/.next/server/pages/get-ecash.js:188:15)
#8 13.70     at processTicksAndRejections (node:internal/process/task_queues:96:5)
#8 13.70     at async getStaticProps (/.next/server/pages/get-ecash.js:383:22)
#8 13.70     at async renderToHTML (/node_modules/next/dist/server/render.js:385:20)
#8 13.70     at async /node_modules/next/dist/export/worker.js:286:36
#8 13.70     at async Span.traceAsyncFn (/node_modules/next/dist/trace/trace.js:79:20)
#8 15.04 Warning: data for page "/blog" is 896 kB which exceeds the threshold of 128 kB, this amount of data can reduce performance.
#8 15.04 See more info here: https://nextjs.org/docs/messages/large-page-data
#8 17.27 info  - Generating static pages (24/97)
#8 21.25 Warning: data for page "/blog/[slug]" (path "/blog/twitter-space-ecash-gunu-kutlamasi-icin-gerceklesen-ama-etkinligi") is 129 kB which exceeds the threshold of 128 kB, this amount of data can reduce performance.
#8 21.25 See more info here: https://nextjs.org/docs/messages/large-page-data
#8 21.37 info  - Generating static pages (48/97)
#8 25.74 info  - Generating static pages (72/97)
#8 29.69 info  - Generating static pages (97/97)
#8 29.69 
#8 29.69 > Build error occurred
#8 29.70 Error: Export encountered errors on following paths:
#8 29.70 	/get-ecash
#8 29.70     at /node_modules/next/dist/export/index.js:415:19
#8 29.70     at runMicrotasks (<anonymous>)
#8 29.70     at processTicksAndRejections (node:internal/process/task_queues:96:5)
#8 29.70     at async Span.traceAsyncFn (/node_modules/next/dist/trace/trace.js:79:20)
#8 29.70     at async /node_modules/next/dist/build/index.js:1400:21
#8 29.70     at async Span.traceAsyncFn (/node_modules/next/dist/trace/trace.js:79:20)
#8 29.70     at async /node_modules/next/dist/build/index.js:1259:17
#8 29.70     at async Span.traceAsyncFn (/node_modules/next/dist/trace/trace.js:79:20)
#8 29.70     at async Object.build [as default] (/node_modules/next/dist/build/index.js:66:29)
#8 ERROR: executor failed running [/bin/sh -c npm run build]: exit code: 1
------
 > [4/4] RUN npm run build:
------
executor failed running [/bin/sh -c npm run build]: exit code: 1
Build preview-e.cash failed with exit code 1
This revision is now accepted and ready to land.Aug 11 2023, 15:41