Page MenuHomePhabricator
Differential D14389

test: Avoid intermittent issues due to async events in validationinterface_tests
ClosedPublic
Actions

Authored by PiRK on Aug 21 2023, 08:25.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC4a3ee7bd6ac6: test: Avoid intermittent issues due to async events in validationinterface_tests
Summary

Currently the tests have many issues:

This is a backport of core#28150

Test Plan

I ran ./src/test/test_bitcoin -t validationinterface_tests/unregister_all_during_call -- -printtoconsole=1 in a loop but was not able to reproduce the intermittent failure locallly.
We can monitor the CI and see if the test keeps failing.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Aug 21 2023, 08:25
Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 21 2023, 08:25
PiRK requested review of this revision.Aug 21 2023, 08:25
teamcity edited the summary of this revision. (Show Details)Aug 21 2023, 08:25
Harbormaster completed remote builds in B24799: Diff 41866.Aug 21 2023, 08:41
PiRK planned changes to this revision.Aug 21 2023, 08:59
PiRK updated this revision to Diff 41867.Aug 21 2023, 09:26
PiRK edited the summary of this revision. (Show Details)

use the same fix as core, use the TestChain100Setup only for the single test case that needs it

Harbormaster completed remote builds in B24800: Diff 41867.Aug 21 2023, 09:38
Fabien accepted this revision.Aug 21 2023, 10:50
This revision is now accepted and ready to land.Aug 21 2023, 10:50
Closed by commit rABC4a3ee7bd6ac6: test: Avoid intermittent issues due to async events in validationinterface_tests (authored by PiRK). · Explain WhyAug 21 2023, 12:30
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC4a3ee7bd6ac6: test: Avoid intermittent issues due to async events in validationinterface_tests.

Revision Contents
Changeset List

PathSize
src/
test/
4 lines

Diff 41872

View Options

src/test/validationinterface_tests.cpp

Loading...