test: Add some coverage for passing fee rates as a string.
Needs RevisionPublic
Actions

Authored by PiRK on Aug 24 2023, 08:11.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Summary

Note that sendmany and sendtoaddress don't have a fee_rate option in our codebase, and there is no bug in send() as we don't have a dedicated fee_rate parameter for this RPC but rather an untyped option which already accepts string values.

This is a backport of core#20573

Test Plan

ninja check-functional

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr20573

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 24832
Build 49254: Build Diff	build-clang · build-diff · build-without-wallet · build-clang-tidy · build-debug
Build 49253: arc lint + arc unit

Event Timeline

PiRK created this revision.Aug 24 2023, 08:11

Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 24 2023, 08:11

PiRK requested review of this revision.Aug 24 2023, 08:11

teamcity edited the summary of this revision. (Show Details)Aug 24 2023, 08:11

Harbormaster completed remote builds in B24832: Diff 41913.Aug 24 2023, 08:28

Why didn't you backport the test cases from wallet_basic.py ?

This revision now requires changes to proceed.Aug 24 2023, 12:10

I'm trying to find out why we don't have a fee_rate option for sendmany and sendtoaddress. It looks like those options were added in core pull requests that we ignored because they are mostly about fee estimation modes.