HomePhabricator

Make AnalyzePSBT next role calculation simple, correct

Description

Make AnalyzePSBT next role calculation simple, correct

Summary:

Set next to"finalizer" when all inputs need finalizing
Note that this assumes that PSBT roles are a complete ordering, which for now and in the future seems to be a correct assumption.

This is a backport of Core PR18224

Test Plan:
ninja && ninja check && test/functional/test_runner.py rpc_psbt

Check that before this patch to psbt.cpp the functional test fails because the "next" role is signer, and after this patch is has the correct "finalizer" value.

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Subscribers: Fabien

Differential Revision: https://reviews.bitcoinabc.org/D8778

Details

Provenance
Gregory Sanders <gsanders87@gmail.com>Authored on Aug 23 2023, 07:06
PiRKCommitted on Aug 23 2023, 09:09
PiRKPushed on Aug 23 2023, 09:09
Reviewer
Restricted Project
Differential Revision
D8778: Make AnalyzePSBT next role calculation simple, correct
Parents
rABC2f08a0b0f989: [Chronik] Update Cargo.lock dependencies to latest version
Branches
Unknown
Tags
Unknown