Page MenuHomePhabricator
Differential D14446

[linter] Fix flake8 E721 warnings
ClosedPublic
Actions

Authored by Fabien on Sep 4 2023, 14:27.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Commits
rABC39883b4df489: [linter] Fix flake8 E721 warnings
Summary

Replace type(x) == Foo with isinstance(x, Foo)

Test Plan
arc lint --everything

Diff Detail

Repository
rABC Bitcoin ABC
Branch
fix_linters
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 24940
Build 49468: Build Diffelectrum-tests
Build 49467: arc lint + arc unit

Event Timeline

Fabien created this revision.Sep 4 2023, 14:27
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 4 2023, 14:27
Fabien requested review of this revision.Sep 4 2023, 14:27
Harbormaster completed remote builds in B24940: Diff 42062.Sep 4 2023, 14:29
PiRK requested changes to this revision.Sep 4 2023, 15:12
PiRK added a subscriber: PiRK.
PiRK added inline comments.
electrum/electrumabc/wallet.py
2689
2692

dito

This revision now requires changes to proceed.Sep 4 2023, 15:12
Fabien updated this revision to Diff 42063.Sep 4 2023, 16:00

Fix misuse of the is keyword

Harbormaster completed remote builds in B24941: Diff 42063.Sep 4 2023, 16:02
PiRK accepted this revision.Sep 4 2023, 16:08
This revision is now accepted and ready to land.Sep 4 2023, 16:08
Closed by commit rABC39883b4df489: [linter] Fix flake8 E721 warnings (authored by Fabien). · Explain WhySep 4 2023, 19:11
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC39883b4df489: [linter] Fix flake8 E721 warnings.

Revision Contents
Changeset List

PathSize
electrum/
electrumabc/
4 lines
4 lines
electrumabc_plugins/
hw_wallet/
2 lines
keepkey/
2 lines
ledger/
4 lines
trezor/
2 lines

Diff 42062

View Options

electrum/electrumabc/paymentrequest.py

Loading...
View Options

electrum/electrumabc/wallet.py

Loading...
View Options

electrum/electrumabc_plugins/hw_wallet/plugin.py

Loading...
View Options

electrum/electrumabc_plugins/keepkey/qt.py

Loading...
View Options

electrum/electrumabc_plugins/ledger/qt.py

Loading...
View Options

electrum/electrumabc_plugins/trezor/qt.py

Loading...