Paths

Table of Contentst

Differential D14447

[electrum] fix compact_size_nbytes for 0-length scripts
ClosedPublic
Actions

Authored by PiRK on Sep 5 2023, 08:06.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC0141616c41ed: [electrum] fix compact_size_nbytes for 0-length scripts

Summary

My previous interpretation of how empty scripts are pushed was wrong. There is a 1-byte compact size (with value 0) even in this case

Test Plan

python test_runner.py

Diff Detail

Repository

rABC Bitcoin ABC

Branch

deser_tx

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 24942
Build 49472: Build Diff	electrum-tests
Build 49471: arc lint + arc unit

Event Timeline

PiRK created this revision.Sep 5 2023, 08:06

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 5 2023, 08:06

PiRK requested review of this revision.Sep 5 2023, 08:06

Harbormaster completed remote builds in B24942: Diff 42066.Sep 5 2023, 08:07

PiRK added a child revision: D14448: [electrum] estime tx size without serializing.Sep 5 2023, 09:21

oups

This revision is now accepted and ready to land.Sep 5 2023, 11:42

Closed by commit rABC0141616c41ed: [electrum] fix compact_size_nbytes for 0-length scripts (authored by PiRK). · Explain WhySep 5 2023, 16:14

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC0141616c41ed: [electrum] fix compact_size_nbytes for 0-length scripts.

Revision Contents
Changeset List

Path

Size

electrum/

electrumabc/

tests/

test_transaction.py

18 lines

transaction.py

4 lines

Diff 42066

View Options

electrum/electrumabc/tests/test_transaction.py