The explorer is currently hard-coded to use the ecash: prefix. This diffs adds on optional chain parameter to the config.toml that can be set to "testnet" to use the ectest prefix instead.
Depends on D14450 for the search bar to work.
Details
Details
- Reviewers
tobias_ruck - Group Reviewers
Restricted Project - Commits
- rABCeb0f9bbf0df1: [explorer] Add test chains address support to the explorer
cd explorer-server && cargo test
Add chain: "testnet" to the config.toml file, then cargo run. Check the addresses are now displayed using the ectest: prefix. Navigate through the transaction and address pages, and use the search bar to check it works as expected.
Repeat with chain: "regtest".
Try again with a wrong chain name, check that cargo run aborts with a meaningful error message.
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- explorer_testnet_addresses
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 24957 Build 49502: Build Diff Build 49501: arc lint + arc unit
Event Timeline
| web/explorer/explorer-server/src/server.rs | ||
|---|---|---|
| 55–59 ↗ | (On Diff #42076) | Also maybe add regtest prefixes? It's actually quite useful in some cases |
| web/explorer/explorer-server/src/server.rs | ||
|---|---|---|
| 50 | It may also be a good idea to use an enum here (enum Chain { Mainnet, Testnet, Regtest }), you can implement FromStr for it, even return an error from there, and then parse it in main using chain.parse | |
| 58 | Are you sure this is reasonable behavouir? If someone specifies "chipnet" or something invalid like that it's going to interpret that as "mainnet". Might be confusing. | |