Page MenuHomePhabricator
Differential D14459

[electrum] remove parse_scriptSig function
ClosedPublic
Actions

Authored by PiRK on Sep 7 2023, 11:49.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCada4267c27ce: [electrum] remove parse_scriptSig function
Summary

Use TxInput.parse_scriptsig instead.

Depends on D14458

Test Plan

python test_runner.py

Send transactions in the application (regular wallet and multisig)

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Sep 7 2023, 11:49
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 7 2023, 11:49
PiRK requested review of this revision.Sep 7 2023, 11:49
Harbormaster completed remote builds in B24972: Diff 42104.Sep 7 2023, 11:51
Fabien requested changes to this revision.Sep 8 2023, 08:23
Fabien added a subscriber: Fabien.
Fabien added inline comments.
electrum/electrumabc/transaction.py
559 ↗(On Diff #42104)

You have the opportunity to gain 1 indentation level:

if txin.is_coinbase():
  return d

[...]
This revision now requires changes to proceed.Sep 8 2023, 08:23
PiRK updated this revision to Diff 42120.Sep 8 2023, 10:36

remove unneccessary indentation level

Harbormaster completed remote builds in B24979: Diff 42120.Sep 8 2023, 10:38
PiRK added a child revision: D14461: [electrum] implement TxInput.to_coin_dict and TxInput.is_complete.Sep 8 2023, 10:49
Fabien accepted this revision.Sep 8 2023, 11:34
This revision is now accepted and ready to land.Sep 8 2023, 11:34
PiRK mentioned this in D14466: [electrum] replace match_decoded function with more explicit functions.Sep 11 2023, 10:45
PiRK updated this revision to Diff 42131.Sep 11 2023, 10:51

rebase

Harbormaster completed remote builds in B24989: Diff 42131.Sep 11 2023, 10:53
Closed by commit rABCada4267c27ce: [electrum] remove parse_scriptSig function (authored by PiRK). · Explain WhySep 12 2023, 10:48
This revision was automatically updated to reflect the committed changes.
PiRK mentioned this in rABC2673549a2fd8: [electrum] replace match_decoded function with more explicit functions.
PiRK added a commit: rABCada4267c27ce: [electrum] remove parse_scriptSig function.

Revision Contents
Changeset List

PathSize
electrum/
electrumabc/
126 lines

Diff 42156

View Options

electrum/electrumabc/transaction.py

Loading...